Merge pull request #5638 from Tyriar/tyriar/comma

Add @stylistic/comma-spacing eslint rule
This commit is contained in:
Daniel Imms
2026-01-31 08:32:49 -08:00
committed by GitHub
11 changed files with 11 additions and 10 deletions
+1 -1
View File
@@ -12,7 +12,7 @@ interface IAttachOptions {
bidirectional?: boolean; bidirectional?: boolean;
} }
export class AttachAddon implements ITerminalAddon , IAttachApi { export class AttachAddon implements ITerminalAddon, IAttachApi {
private _socket: WebSocket; private _socket: WebSocket;
private _bidirectional: boolean; private _bidirectional: boolean;
private _disposables: IDisposable[] = []; private _disposables: IDisposable[] = [];
+1 -1
View File
@@ -33,7 +33,7 @@ function _getComputedStyle(el: HTMLElement): CSSStyleDeclaration {
return getWindow(el).getComputedStyle(el, null); return getWindow(el).getComputedStyle(el, null);
} }
export class FitAddon implements ITerminalAddon , IFitApi { export class FitAddon implements ITerminalAddon, IFitApi {
private _terminal: Terminal | undefined; private _terminal: Terminal | undefined;
public activate(terminal: Terminal): void { public activate(terminal: Terminal): void {
+1 -1
View File
@@ -48,7 +48,7 @@ const enum GaStatus {
} }
export class ImageAddon implements ITerminalAddon , IImageApi { export class ImageAddon implements ITerminalAddon, IImageApi {
private _opts: IImageAddonOptions; private _opts: IImageAddonOptions;
private _defaultOpts: IImageAddonOptions; private _defaultOpts: IImageAddonOptions;
private _storage: ImageStorage | undefined; private _storage: ImageStorage | undefined;
+1 -1
View File
@@ -13,7 +13,7 @@ export interface ITerminalAddon {
dispose(): void; dispose(): void;
} }
export class LigaturesAddon implements ITerminalAddon , ILigaturesApi { export class LigaturesAddon implements ITerminalAddon, ILigaturesApi {
private readonly _fallbackLigatures: string[]; private readonly _fallbackLigatures: string[];
private readonly _fontFeatureSettings?: string; private readonly _fontFeatureSettings?: string;
+1 -1
View File
@@ -457,7 +457,7 @@ class StringSerializeHandler extends BaseSerializeHandler {
} }
} }
export class SerializeAddon implements ITerminalAddon , ISerializeApi { export class SerializeAddon implements ITerminalAddon, ISerializeApi {
private _terminal: Terminal | undefined; private _terminal: Terminal | undefined;
public activate(terminal: Terminal): void { public activate(terminal: Terminal): void {
@@ -9,7 +9,7 @@ import type { Terminal, ITerminalAddon, IUnicodeHandling } from '@xterm/xterm';
import type { UnicodeGraphemesAddon as IUnicodeGraphemesApi } from '@xterm/addon-unicode-graphemes'; import type { UnicodeGraphemesAddon as IUnicodeGraphemesApi } from '@xterm/addon-unicode-graphemes';
import { UnicodeGraphemeProvider } from './UnicodeGraphemeProvider'; import { UnicodeGraphemeProvider } from './UnicodeGraphemeProvider';
export class UnicodeGraphemesAddon implements ITerminalAddon , IUnicodeGraphemesApi { export class UnicodeGraphemesAddon implements ITerminalAddon, IUnicodeGraphemesApi {
private _provider15Graphemes?: UnicodeGraphemeProvider; private _provider15Graphemes?: UnicodeGraphemeProvider;
private _provider15?: UnicodeGraphemeProvider; private _provider15?: UnicodeGraphemeProvider;
private _unicode?: IUnicodeHandling; private _unicode?: IUnicodeHandling;
+1 -1
View File
@@ -9,7 +9,7 @@ import type { Terminal, ITerminalAddon } from '@xterm/xterm';
import type { Unicode11Addon as IUnicode11Api } from '@xterm/addon-unicode11'; import type { Unicode11Addon as IUnicode11Api } from '@xterm/addon-unicode11';
import { UnicodeV11 } from './UnicodeV11'; import { UnicodeV11 } from './UnicodeV11';
export class Unicode11Addon implements ITerminalAddon , IUnicode11Api { export class Unicode11Addon implements ITerminalAddon, IUnicode11Api {
public activate(terminal: Terminal): void { public activate(terminal: Terminal): void {
terminal.unicode.register(new UnicodeV11()); terminal.unicode.register(new UnicodeV11());
} }
+1 -1
View File
@@ -35,7 +35,7 @@ function handleLink(event: MouseEvent, uri: string): void {
} }
} }
export class WebLinksAddon implements ITerminalAddon , IWebLinksApi { export class WebLinksAddon implements ITerminalAddon, IWebLinksApi {
private _terminal: Terminal | undefined; private _terminal: Terminal | undefined;
private _linkProvider: IDisposable | undefined; private _linkProvider: IDisposable | undefined;
+1 -1
View File
@@ -14,7 +14,7 @@ import { IWebGL2RenderingContext } from './Types';
import { WebglRenderer } from './WebglRenderer'; import { WebglRenderer } from './WebglRenderer';
import { Emitter, EventUtils } from 'common/Event'; import { Emitter, EventUtils } from 'common/Event';
export class WebglAddon extends Disposable implements ITerminalAddon , IWebglApi { export class WebglAddon extends Disposable implements ITerminalAddon, IWebglApi {
private _terminal?: Terminal; private _terminal?: Terminal;
private _renderer?: WebglRenderer; private _renderer?: WebglRenderer;
+1
View File
@@ -35,6 +35,7 @@ export default tseslint.config(
} }
}, },
rules: { rules: {
'@stylistic/comma-spacing': ['warn', { before: false, after: true }],
'@stylistic/indent': ['warn', 2], '@stylistic/indent': ['warn', 2],
'@stylistic/semi': ['warn', 'always'], '@stylistic/semi': ['warn', 'always'],
'@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: true }], '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: true }],
@@ -28,7 +28,7 @@ describe('RendererUtils', () => {
line = 2; line = 2;
variantOffset = 0; variantOffset = 0;
cells = [cellWidth, cellWidth, doubleCellWidth, doubleCellWidth]; cells = [cellWidth, cellWidth, doubleCellWidth, doubleCellWidth];
result = [3, 2, 0 ,2]; result = [3, 2, 0, 2];
for (let index = 0; index < cells.length; index++) { for (let index = 0; index < cells.length; index++) {
const cell = cells[index]; const cell = cells[index];
variantOffset = computeNextVariantOffset(cell, line, variantOffset); variantOffset = computeNextVariantOffset(cell, line, variantOffset);