Merge pull request #2388 from ShahzadUmair/Support-for-bubbling-scroll

Support for bubbling scroll events to parent(s)
This commit is contained in:
Daniel Imms
2019-08-22 09:12:41 -07:00
committed by GitHub
4 changed files with 33 additions and 15 deletions
+6 -4
View File
@@ -1037,8 +1037,9 @@ export class Terminal extends Disposable implements ITerminal, IDisposable, IInp
// the shell for example
this.register(addDisposableDomListener(el, 'wheel', (ev: WheelEvent) => {
if (this.mouseEvents) return;
this.viewport.onWheel(ev);
return this.cancel(ev);
if (!this.viewport.onWheel(ev)) {
return this.cancel(ev);
}
}));
this.register(addDisposableDomListener(el, 'touchstart', (ev: TouchEvent) => {
@@ -1049,8 +1050,9 @@ export class Terminal extends Disposable implements ITerminal, IDisposable, IInp
this.register(addDisposableDomListener(el, 'touchmove', (ev: TouchEvent) => {
if (this.mouseEvents) return;
this.viewport.onTouchMove(ev);
return this.cancel(ev);
if (!this.viewport.onTouchMove(ev)) {
return this.cancel(ev);
}
}));
}