Merge pull request #5641 from Tyriar/padStart

Use native padStart over custom impl
This commit is contained in:
Daniel Imms
2026-01-31 10:25:24 -08:00
committed by GitHub
2 changed files with 4 additions and 25 deletions
@@ -397,7 +397,7 @@ export class DomRendererRowFactory {
break;
case Attributes.CM_RGB:
resolvedBg = channels.toColor(bg >> 16, bg >> 8 & 0xFF, bg & 0xFF);
this._addStyle(charElement, `background-color:#${padStart((bg >>> 0).toString(16), '0', 6)}`);
this._addStyle(charElement, `background-color:#${(bg >>> 0).toString(16).padStart(6, '0')}`);
break;
case Attributes.CM_DEFAULT:
default:
@@ -434,7 +434,7 @@ export class DomRendererRowFactory {
(fg ) & 0xFF
);
if (!this._applyMinimumContrast(charElement, resolvedBg, color, cell, bgOverride, fgOverride)) {
this._addStyle(charElement, `color:#${padStart(fg.toString(16), '0', 6)}`);
this._addStyle(charElement, `color:#${fg.toString(16).padStart(6, '0')}`);
}
break;
case Attributes.CM_DEFAULT:
@@ -537,10 +537,3 @@ export class DomRendererRowFactory {
(start[1] < end[1] && y === start[1] && x >= start[0]);
}
}
function padStart(text: string, padChar: string, length: number): string {
while (text.length < length) {
text = padChar + text;
}
return text;
}