move line content functions to TerminalLine

This commit is contained in:
Jörg Breitbart
2018-08-26 19:24:49 +02:00
parent 77cb697990
commit 9c68eb3b11
4 changed files with 82 additions and 84 deletions
+54 -67
View File
@@ -4,7 +4,7 @@
* @license MIT * @license MIT
*/ */
import { CharData, IInputHandler, IDcsHandler, IEscapeSequenceParser, IBuffer, IInputHandlingTerminal } from './Types'; import { IInputHandler, IDcsHandler, IEscapeSequenceParser, IBuffer, IInputHandlingTerminal } from './Types';
import { C0, C1 } from './common/data/EscapeSequences'; import { C0, C1 } from './common/data/EscapeSequences';
import { CHARSETS, DEFAULT_CHARSET } from './core/data/Charsets'; import { CHARSETS, DEFAULT_CHARSET } from './core/data/Charsets';
import { CHAR_DATA_CHAR_INDEX, CHAR_DATA_WIDTH_INDEX, CHAR_DATA_CODE_INDEX, DEFAULT_ATTR, NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE } from './Buffer'; import { CHAR_DATA_CHAR_INDEX, CHAR_DATA_WIDTH_INDEX, CHAR_DATA_CODE_INDEX, DEFAULT_ATTR, NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE } from './Buffer';
@@ -550,20 +550,12 @@ export class InputHandler extends Disposable implements IInputHandler {
* Insert Ps (Blank) Character(s) (default = 1) (ICH). * Insert Ps (Blank) Character(s) (default = 1) (ICH).
*/ */
public insertChars(params: number[]): void { public insertChars(params: number[]): void {
let param = params[0]; this._terminal.buffer.lines.get(this._terminal.buffer.y + this._terminal.buffer.ybase).insertCells(
if (param < 1) param = 1; this._terminal.buffer.x,
params[0] || 1,
// make buffer local for faster access [this._terminal.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]
const buffer = this._terminal.buffer; );
this._terminal.updateRange(this._terminal.buffer.y);
const row = buffer.y + buffer.ybase;
let j = buffer.x;
const ch: CharData = [this._terminal.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]; // xterm
while (param-- && j < this._terminal.cols) {
buffer.lines.get(row).splice(j++, 0, ch);
buffer.lines.get(row).pop();
}
} }
/** /**
@@ -723,6 +715,21 @@ export class InputHandler extends Disposable implements IInputHandler {
} }
} }
/**
* Helper method to erase cells in a terminal row.
* The cell gets replaced with the eraseChar of the terminal.
* @param y row index
* @param start first cell index to be erased
* @param end end - 1 is last erased cell
*/
private _eraseInBufferLine(y: number, start: number, end: number): void {
this._terminal.buffer.lines.get(this._terminal.buffer.ybase + y).replaceCells(
start,
end,
[this._terminal.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]
);
}
/** /**
* CSI Ps J Erase in Display (ED). * CSI Ps J Erase in Display (ED).
* Ps = 0 -> Erase Below (default). * Ps = 0 -> Erase Below (default).
@@ -739,22 +746,24 @@ export class InputHandler extends Disposable implements IInputHandler {
let j; let j;
switch (params[0]) { switch (params[0]) {
case 0: case 0:
this._terminal.eraseRight(this._terminal.buffer.x, this._terminal.buffer.y); j = this._terminal.buffer.y;
j = this._terminal.buffer.y + 1; this._terminal.updateRange(j);
for (; j < this._terminal.rows; j++) { this._eraseInBufferLine(j++, this._terminal.buffer.x, this._terminal.cols);
this._terminal.eraseLine(j); for (; j < this._terminal.rows; j++) this._eraseInBufferLine(j, 0, this._terminal.cols);
} this._terminal.updateRange(j);
break; break;
case 1: case 1:
this._terminal.eraseLeft(this._terminal.buffer.x, this._terminal.buffer.y);
j = this._terminal.buffer.y; j = this._terminal.buffer.y;
while (j--) { this._terminal.updateRange(j);
this._terminal.eraseLine(j); this._eraseInBufferLine(j, 0, this._terminal.buffer.x + 1);
} while (j--) this._eraseInBufferLine(j, 0, this._terminal.cols);
this._terminal.updateRange(0);
break; break;
case 2: case 2:
j = this._terminal.rows; j = this._terminal.rows;
while (j--) this._terminal.eraseLine(j); this._terminal.updateRange(j - 1);
while (j--) this._eraseInBufferLine(j, 0, this._terminal.cols);
this._terminal.updateRange(0);
break; break;
case 3: case 3:
// Clear scrollback (everything not in viewport) // Clear scrollback (everything not in viewport)
@@ -784,15 +793,16 @@ export class InputHandler extends Disposable implements IInputHandler {
public eraseInLine(params: number[]): void { public eraseInLine(params: number[]): void {
switch (params[0]) { switch (params[0]) {
case 0: case 0:
this._terminal.eraseRight(this._terminal.buffer.x, this._terminal.buffer.y); this._eraseInBufferLine(this._terminal.buffer.y, this._terminal.buffer.x, this._terminal.cols);
break; break;
case 1: case 1:
this._terminal.eraseLeft(this._terminal.buffer.x, this._terminal.buffer.y); this._eraseInBufferLine(this._terminal.buffer.y, 0, this._terminal.buffer.x + 1);
break; break;
case 2: case 2:
this._terminal.eraseLine(this._terminal.buffer.y); this._eraseInBufferLine(this._terminal.buffer.y, 0, this._terminal.cols);
break; break;
} }
this._terminal.updateRange(this._terminal.buffer.y);
} }
/** /**
@@ -859,22 +869,12 @@ export class InputHandler extends Disposable implements IInputHandler {
* Delete Ps Character(s) (default = 1) (DCH). * Delete Ps Character(s) (default = 1) (DCH).
*/ */
public deleteChars(params: number[]): void { public deleteChars(params: number[]): void {
let param: number = params[0]; this._terminal.buffer.lines.get(this._terminal.buffer.y + this._terminal.buffer.ybase).deleteCells(
if (param < 1) { this._terminal.buffer.x,
param = 1; params[0] || 1,
} [this._terminal.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]
);
// make buffer local for faster access this._terminal.updateRange(this._terminal.buffer.y);
const buffer = this._terminal.buffer;
const row = buffer.y + buffer.ybase;
const ch: CharData = [this._terminal.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]; // xterm
while (param--) {
buffer.lines.get(row).splice(buffer.x, 1);
buffer.lines.get(row).push(ch);
}
this._terminal.updateRange(buffer.y);
} }
/** /**
@@ -920,21 +920,11 @@ export class InputHandler extends Disposable implements IInputHandler {
* Erase Ps Character(s) (default = 1) (ECH). * Erase Ps Character(s) (default = 1) (ECH).
*/ */
public eraseChars(params: number[]): void { public eraseChars(params: number[]): void {
let param = params[0]; this._terminal.buffer.lines.get(this._terminal.buffer.y + this._terminal.buffer.ybase).replaceCells(
if (param < 1) { this._terminal.buffer.x,
param = 1; this._terminal.buffer.x + (params[0] || 1),
} [this._terminal.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]
);
// make buffer local for faster access
const buffer = this._terminal.buffer;
const row = buffer.y + buffer.ybase;
let j = buffer.x;
const ch: CharData = [this._terminal.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]; // xterm
while (param-- && j < this._terminal.cols) {
buffer.lines.get(row).set(j++, ch);
}
} }
/** /**
@@ -986,17 +976,14 @@ export class InputHandler extends Disposable implements IInputHandler {
* CSI Ps b Repeat the preceding graphic character Ps times (REP). * CSI Ps b Repeat the preceding graphic character Ps times (REP).
*/ */
public repeatPrecedingCharacter(params: number[]): void { public repeatPrecedingCharacter(params: number[]): void {
let param = params[0] || 1;
// make buffer local for faster access // make buffer local for faster access
const buffer = this._terminal.buffer; const buffer = this._terminal.buffer;
const line = buffer.lines.get(buffer.ybase + buffer.y); const line = buffer.lines.get(buffer.ybase + buffer.y);
const ch = line.get(buffer.x - 1) || [DEFAULT_ATTR, NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]; line.replaceCells(buffer.x,
buffer.x + (params[0] || 1),
while (param--) { line.get(buffer.x - 1) || [DEFAULT_ATTR, NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]
line.set(buffer.x++, ch); );
} // FIXME: no updateRange here?
} }
/** /**
+1
View File
@@ -105,6 +105,7 @@ if (os.platform() !== 'win32') {
// omit stack trace for escape sequence files // omit stack trace for escape sequence files
Error.stackTraceLimit = 0; Error.stackTraceLimit = 0;
const files = glob.sync('**/escape_sequence_files/*.in', { cwd: path.join(__dirname, '..')}); const files = glob.sync('**/escape_sequence_files/*.in', { cwd: path.join(__dirname, '..')});
// for (let i = 0; i < files.length; ++i) console.debug(i, files[i]);
// only successful tests for now // only successful tests for now
const skip = [ const skip = [
10, 16, 17, 19, 32, 33, 34, 35, 36, 39, 10, 16, 17, 19, 32, 33, 34, 35, 36, 39,
+4 -15
View File
@@ -1715,13 +1715,8 @@ export class Terminal extends EventEmitter implements ITerminal, IDisposable, II
*/ */
public eraseRight(x: number, y: number): void { public eraseRight(x: number, y: number): void {
const line = this.buffer.lines.get(this.buffer.ybase + y); const line = this.buffer.lines.get(this.buffer.ybase + y);
if (!line) { if (!line) return;
return; line.replaceCells(x, this.cols, [this.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]);
}
const ch: CharData = [this.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]; // xterm
for (; x < this.cols; x++) {
line.set(x, ch);
}
this.updateRange(y); this.updateRange(y);
} }
@@ -1732,14 +1727,8 @@ export class Terminal extends EventEmitter implements ITerminal, IDisposable, II
*/ */
public eraseLeft(x: number, y: number): void { public eraseLeft(x: number, y: number): void {
const line = this.buffer.lines.get(this.buffer.ybase + y); const line = this.buffer.lines.get(this.buffer.ybase + y);
if (!line) { if (!line) return;
return; line.replaceCells(0, x + 1, [this.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]);
}
const ch: CharData = [this.eraseAttr(), NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]; // xterm
x++;
while (x--) {
line.set(x, ch);
}
this.updateRange(y); this.updateRange(y);
} }
+23 -2
View File
@@ -12,9 +12,12 @@ import { NULL_CELL_CODE, NULL_CELL_WIDTH, NULL_CELL_CHAR } from './Buffer';
* typed array based line data. * typed array based line data.
* TODO: move typical line actions in `InputHandler` and `Terminal` here: * TODO: move typical line actions in `InputHandler` and `Terminal` here:
* - create blank line - done * - create blank line - done
* - insert cells * - insert cells - done
* - remove cells * - remove cells - done
* - maybe Buffer.translateBufferLineToString * - maybe Buffer.translateBufferLineToString
*
* next steps towards typed array:
* - replace all external push/pop/splice accesses
*/ */
export class TerminalLine { export class TerminalLine {
static defaultCell: CharData = [0, NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]; static defaultCell: CharData = [0, NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE];
@@ -80,4 +83,22 @@ export class TerminalLine {
toArray(): CharData[] { toArray(): CharData[] {
return this._data; return this._data;
} }
/** insert n cells ch at pos, right cells are lost (stable length) */
insertCells(pos: number, n: number, ch: CharData): void {
while (n--) {
this.splice(pos, 0, ch);
this.pop();
}
}
/** delete n cells at pos, right side is filled with fill (stable length) */
deleteCells(pos: number, n: number, fill: CharData): void {
while (n--) {
this.splice(pos, 1);
this.push(fill);
}
}
/** replace cells from pos to pos + n - 1 with fill */
replaceCells(start: number, end: number, fill: CharData): void {
while (start < end && start < this.length) this.set(start++, fill); // Note: fill is not cloned
}
} }