Separate link provider service from linkifier

This commit is contained in:
Daniel Imms
2023-12-23 08:21:35 -08:00
parent b3737d6ff0
commit 8733d2cfa2
11 changed files with 77 additions and 47 deletions
+1 -1
View File
@@ -37,7 +37,7 @@ export class CanvasAddon extends Disposable implements ITerminalAddon , ICanvasA
const coreService = core.coreService; const coreService = core.coreService;
const optionsService = core.optionsService; const optionsService = core.optionsService;
const screenElement = core.screenElement!; const screenElement = core.screenElement!;
const linkifier = core.linkifier2; const linkifier = core.linkifier!;
const unsafeCore = core as any; const unsafeCore = core as any;
const bufferService: IBufferService = unsafeCore._bufferService; const bufferService: IBufferService = unsafeCore._bufferService;
+1 -1
View File
@@ -81,7 +81,7 @@ export class WebglRenderer extends Disposable implements IRenderer {
this._core = (this._terminal as any)._core; this._core = (this._terminal as any)._core;
this._renderLayers = [ this._renderLayers = [
new LinkRenderLayer(this._core.screenElement!, 2, this._terminal, this._core.linkifier2, this._coreBrowserService, _optionsService, this._themeService) new LinkRenderLayer(this._core.screenElement!, 2, this._terminal, this._core.linkifier!, this._coreBrowserService, _optionsService, this._themeService)
]; ];
this.dimensions = createRenderDimensions(); this.dimensions = createRenderDimensions();
this._devicePixelRatio = this._coreBrowserService.dpr; this._devicePixelRatio = this._coreBrowserService.dpr;
+2 -1
View File
@@ -8,6 +8,7 @@ import { IBufferService } from 'common/services/Services';
import { Linkifier2 } from 'browser/Linkifier2'; import { Linkifier2 } from 'browser/Linkifier2';
import { MockBufferService } from 'common/TestUtils.test'; import { MockBufferService } from 'common/TestUtils.test';
import { ILink } from 'browser/Types'; import { ILink } from 'browser/Types';
import { LinkProviderService } from 'browser/services/LinkProviderService';
class TestLinkifier2 extends Linkifier2 { class TestLinkifier2 extends Linkifier2 {
public set currentLink(link: any) { public set currentLink(link: any) {
@@ -44,7 +45,7 @@ describe('Linkifier2', () => {
beforeEach(() => { beforeEach(() => {
bufferService = new MockBufferService(100, 10); bufferService = new MockBufferService(100, 10);
linkifier = new TestLinkifier2(bufferService); linkifier = new TestLinkifier2(bufferService, new LinkProviderService());
linkifier.currentLink = { linkifier.currentLink = {
link, link,
state: { state: {
+7 -22
View File
@@ -4,18 +4,17 @@
*/ */
import { addDisposableDomListener } from 'browser/Lifecycle'; import { addDisposableDomListener } from 'browser/Lifecycle';
import { IBufferCellPosition, ILink, ILinkDecorations, ILinkProvider, ILinkWithState, ILinkifier2, ILinkifierEvent } from 'browser/Types'; import { IBufferCellPosition, ILink, ILinkDecorations, ILinkWithState, ILinkifier2, ILinkifierEvent } from 'browser/Types';
import { EventEmitter } from 'common/EventEmitter'; import { EventEmitter } from 'common/EventEmitter';
import { Disposable, disposeArray, getDisposeArrayDisposable, toDisposable } from 'common/Lifecycle'; import { Disposable, disposeArray, getDisposeArrayDisposable, toDisposable } from 'common/Lifecycle';
import { IDisposable } from 'common/Types'; import { IDisposable } from 'common/Types';
import { IBufferService } from 'common/services/Services'; import { IBufferService } from 'common/services/Services';
import { IMouseService, IRenderService } from './services/Services'; import { ILinkProviderService, IMouseService, IRenderService } from './services/Services';
export class Linkifier2 extends Disposable implements ILinkifier2 { export class Linkifier2 extends Disposable implements ILinkifier2 {
private _element: HTMLElement | undefined; private _element: HTMLElement | undefined;
private _mouseService: IMouseService | undefined; private _mouseService: IMouseService | undefined;
private _renderService: IRenderService | undefined; private _renderService: IRenderService | undefined;
private _linkProviders: ILinkProvider[] = [];
public get currentLink(): ILinkWithState | undefined { return this._currentLink; } public get currentLink(): ILinkWithState | undefined { return this._currentLink; }
protected _currentLink: ILinkWithState | undefined; protected _currentLink: ILinkWithState | undefined;
private _mouseDownLink: ILinkWithState | undefined; private _mouseDownLink: ILinkWithState | undefined;
@@ -33,14 +32,14 @@ export class Linkifier2 extends Disposable implements ILinkifier2 {
public readonly onHideLinkUnderline = this._onHideLinkUnderline.event; public readonly onHideLinkUnderline = this._onHideLinkUnderline.event;
constructor( constructor(
@IBufferService private readonly _bufferService: IBufferService @IBufferService private readonly _bufferService: IBufferService,
@ILinkProviderService private readonly _linkProviderService: ILinkProviderService
) { ) {
super(); super();
this.register(getDisposeArrayDisposable(this._linkCacheDisposables)); this.register(getDisposeArrayDisposable(this._linkCacheDisposables));
this.register(toDisposable(() => { this.register(toDisposable(() => {
this._lastMouseEvent = undefined; this._lastMouseEvent = undefined;
// Clear out link providers as they could easily cause an embedder memory leak // Clear out link providers as they could easily cause an embedder memory leak
this._linkProviders.length = 0;
this._activeProviderReplies?.clear(); this._activeProviderReplies?.clear();
})); }));
// Listen to resize to catch the case where it's resized and the cursor is out of the viewport. // Listen to resize to catch the case where it's resized and the cursor is out of the viewport.
@@ -50,20 +49,6 @@ export class Linkifier2 extends Disposable implements ILinkifier2 {
})); }));
} }
public registerLinkProvider(linkProvider: ILinkProvider): IDisposable {
this._linkProviders.push(linkProvider);
return {
dispose: () => {
// Remove the link provider from the list
const providerIndex = this._linkProviders.indexOf(linkProvider);
if (providerIndex !== -1) {
this._linkProviders.splice(providerIndex, 1);
}
}
};
}
public attachToDom(element: HTMLElement, mouseService: IMouseService, renderService: IRenderService): void { public attachToDom(element: HTMLElement, mouseService: IMouseService, renderService: IRenderService): void {
this._element = element; this._element = element;
this._mouseService = mouseService; this._mouseService = mouseService;
@@ -145,7 +130,7 @@ export class Linkifier2 extends Disposable implements ILinkifier2 {
let linkProvided = false; let linkProvided = false;
// There is no link cached, so ask for one // There is no link cached, so ask for one
for (const [i, linkProvider] of this._linkProviders.entries()) { for (const [i, linkProvider] of this._linkProviderService.linkProviders.entries()) {
if (useLineCache) { if (useLineCache) {
const existingReply = this._activeProviderReplies?.get(i); const existingReply = this._activeProviderReplies?.get(i);
// If there isn't a reply, the provider hasn't responded yet. // If there isn't a reply, the provider hasn't responded yet.
@@ -167,7 +152,7 @@ export class Linkifier2 extends Disposable implements ILinkifier2 {
// If all providers have responded, remove lower priority links that intersect ranges of // If all providers have responded, remove lower priority links that intersect ranges of
// higher priority links // higher priority links
if (this._activeProviderReplies?.size === this._linkProviders.length) { if (this._activeProviderReplies?.size === this._linkProviderService.linkProviders.length) {
this._removeIntersectingLinks(position.y, this._activeProviderReplies); this._removeIntersectingLinks(position.y, this._activeProviderReplies);
} }
}); });
@@ -223,7 +208,7 @@ export class Linkifier2 extends Disposable implements ILinkifier2 {
} }
// Check if all the providers have responded // Check if all the providers have responded
if (this._activeProviderReplies.size === this._linkProviders.length && !linkProvided) { if (this._activeProviderReplies.size === this._linkProviderService.linkProviders.length && !linkProvided) {
// Respect the order of the link providers // Respect the order of the link providers
for (let j = 0; j < this._activeProviderReplies.size; j++) { for (let j = 0; j < this._activeProviderReplies.size; j++) {
const currentLink = this._activeProviderReplies.get(j)?.find(link => this._linkAtPosition(link.link, position)); const currentLink = this._activeProviderReplies.get(j)?.find(link => this._linkAtPosition(link.link, position));
+2 -1
View File
@@ -3,7 +3,8 @@
* @license MIT * @license MIT
*/ */
import { IBufferRange, ILink, ILinkProvider } from 'browser/Types'; import { IBufferRange, ILink } from 'browser/Types';
import { ILinkProvider } from 'browser/services/Services';
import { CellData } from 'common/buffer/CellData'; import { CellData } from 'common/buffer/CellData';
import { IBufferService, IOptionsService, IOscLinkService } from 'common/services/Services'; import { IBufferService, IOptionsService, IOscLinkService } from 'common/services/Services';
+20 -12
View File
@@ -39,7 +39,7 @@ import { CoreBrowserService } from 'browser/services/CoreBrowserService';
import { MouseService } from 'browser/services/MouseService'; import { MouseService } from 'browser/services/MouseService';
import { RenderService } from 'browser/services/RenderService'; import { RenderService } from 'browser/services/RenderService';
import { SelectionService } from 'browser/services/SelectionService'; import { SelectionService } from 'browser/services/SelectionService';
import { ICharSizeService, ICharacterJoinerService, ICoreBrowserService, IMouseService, IRenderService, ISelectionService, IThemeService } from 'browser/services/Services'; import { ICharSizeService, ICharacterJoinerService, ICoreBrowserService, ILinkProviderService, IMouseService, IRenderService, ISelectionService, IThemeService } from 'browser/services/Services';
import { ThemeService } from 'browser/services/ThemeService'; import { ThemeService } from 'browser/services/ThemeService';
import { color, rgba } from 'common/Color'; import { color, rgba } from 'common/Color';
import { CoreTerminal } from 'common/CoreTerminal'; import { CoreTerminal } from 'common/CoreTerminal';
@@ -57,6 +57,7 @@ import { IDecorationService } from 'common/services/Services';
import { IDecoration, IDecorationOptions, IDisposable, ILinkProvider, IMarker } from '@xterm/xterm'; import { IDecoration, IDecorationOptions, IDisposable, ILinkProvider, IMarker } from '@xterm/xterm';
import { WindowsOptionsReportType } from '../common/InputHandler'; import { WindowsOptionsReportType } from '../common/InputHandler';
import { AccessibilityManager } from './AccessibilityManager'; import { AccessibilityManager } from './AccessibilityManager';
import { LinkProviderService } from 'browser/services/LinkProviderService';
export class Terminal extends CoreTerminal implements ITerminal { export class Terminal extends CoreTerminal implements ITerminal {
public textarea: HTMLTextAreaElement | undefined; public textarea: HTMLTextAreaElement | undefined;
@@ -69,6 +70,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
private _helperContainer: HTMLElement | undefined; private _helperContainer: HTMLElement | undefined;
private _compositionView: HTMLElement | undefined; private _compositionView: HTMLElement | undefined;
public linkifier: ILinkifier2 | undefined;
private _overviewRulerRenderer: OverviewRulerRenderer | undefined; private _overviewRulerRenderer: OverviewRulerRenderer | undefined;
public browser: IBrowser = Browser as any; public browser: IBrowser = Browser as any;
@@ -76,8 +78,11 @@ export class Terminal extends CoreTerminal implements ITerminal {
private _customKeyEventHandler: CustomKeyEventHandler | undefined; private _customKeyEventHandler: CustomKeyEventHandler | undefined;
private _customWheelEventHandler: CustomWheelEventHandler | undefined; private _customWheelEventHandler: CustomWheelEventHandler | undefined;
// browser services // Browser services
private _decorationService: DecorationService; private _decorationService: DecorationService;
private _linkProviderService: ILinkProviderService;
// Optional browser services
private _charSizeService: ICharSizeService | undefined; private _charSizeService: ICharSizeService | undefined;
private _coreBrowserService: ICoreBrowserService | undefined; private _coreBrowserService: ICoreBrowserService | undefined;
private _mouseService: IMouseService | undefined; private _mouseService: IMouseService | undefined;
@@ -113,7 +118,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
*/ */
private _unprocessedDeadKey: boolean = false; private _unprocessedDeadKey: boolean = false;
public linkifier2: ILinkifier2;
public viewport: IViewport | undefined; public viewport: IViewport | undefined;
private _compositionHelper: ICompositionHelper | undefined; private _compositionHelper: ICompositionHelper | undefined;
private _accessibilityManager: MutableDisposable<AccessibilityManager> = this.register(new MutableDisposable()); private _accessibilityManager: MutableDisposable<AccessibilityManager> = this.register(new MutableDisposable());
@@ -149,10 +153,11 @@ export class Terminal extends CoreTerminal implements ITerminal {
this._setup(); this._setup();
this.linkifier2 = this.register(this._instantiationService.createInstance(Linkifier2));
this.linkifier2.registerLinkProvider(this._instantiationService.createInstance(OscLinkProvider));
this._decorationService = this._instantiationService.createInstance(DecorationService); this._decorationService = this._instantiationService.createInstance(DecorationService);
this._instantiationService.setService(IDecorationService, this._decorationService); this._instantiationService.setService(IDecorationService, this._decorationService);
this._linkProviderService = this._instantiationService.createInstance(LinkProviderService);
this._instantiationService.setService(ILinkProviderService, this._linkProviderService);
this._linkProviderService.registerLinkProvider(this._instantiationService.createInstance(OscLinkProvider));
// Setup InputHandler listeners // Setup InputHandler listeners
this.register(this._inputHandler.onRequestBell(() => this._onBell.fire())); this.register(this._inputHandler.onRequestBell(() => this._onBell.fire()));
@@ -482,6 +487,13 @@ export class Terminal extends CoreTerminal implements ITerminal {
this._compositionHelper = this._instantiationService.createInstance(CompositionHelper, this.textarea, this._compositionView); this._compositionHelper = this._instantiationService.createInstance(CompositionHelper, this.textarea, this._compositionView);
this._helperContainer.appendChild(this._compositionView); this._helperContainer.appendChild(this._compositionView);
this._mouseService = this._instantiationService.createInstance(MouseService);
this._instantiationService.setService(IMouseService, this._mouseService);
this.linkifier = this.register(this._instantiationService.createInstance(Linkifier2));
// TODO: Move into ctor
this.linkifier.attachToDom(this.screenElement, this._mouseService, this._renderService);
// Performance: Add viewport and helper elements from the fragment // Performance: Add viewport and helper elements from the fragment
this.element.appendChild(fragment); this.element.appendChild(fragment);
@@ -493,9 +505,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
this._renderService.setRenderer(this._createRenderer()); this._renderService.setRenderer(this._createRenderer());
} }
this._mouseService = this._instantiationService.createInstance(MouseService);
this._instantiationService.setService(IMouseService, this._mouseService);
this.viewport = this._instantiationService.createInstance(Viewport, this._viewportElement, this._viewportScrollArea); this.viewport = this._instantiationService.createInstance(Viewport, this._viewportElement, this._viewportScrollArea);
this.viewport.onRequestScrollLines(e => this.scrollLines(e.amount, e.suppressScrollEvent, ScrollSource.VIEWPORT)), this.viewport.onRequestScrollLines(e => this.scrollLines(e.amount, e.suppressScrollEvent, ScrollSource.VIEWPORT)),
this.register(this._inputHandler.onRequestSyncScrollBar(() => this.viewport!.syncScrollArea())); this.register(this._inputHandler.onRequestSyncScrollBar(() => this.viewport!.syncScrollArea()));
@@ -513,7 +522,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
this._selectionService = this.register(this._instantiationService.createInstance(SelectionService, this._selectionService = this.register(this._instantiationService.createInstance(SelectionService,
this.element, this.element,
this.screenElement, this.screenElement,
this.linkifier2 this.linkifier
)); ));
this._instantiationService.setService(ISelectionService, this._selectionService); this._instantiationService.setService(ISelectionService, this._selectionService);
this.register(this._selectionService.onRequestScrollLines(e => this.scrollLines(e.amount, e.suppressScrollEvent))); this.register(this._selectionService.onRequestScrollLines(e => this.scrollLines(e.amount, e.suppressScrollEvent)));
@@ -533,7 +542,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
})); }));
this.register(addDisposableDomListener(this._viewportElement, 'scroll', () => this._selectionService!.refresh())); this.register(addDisposableDomListener(this._viewportElement, 'scroll', () => this._selectionService!.refresh()));
this.linkifier2.attachToDom(this.screenElement, this._mouseService, this._renderService);
this.register(this._instantiationService.createInstance(BufferDecorationRenderer, this.screenElement)); this.register(this._instantiationService.createInstance(BufferDecorationRenderer, this.screenElement));
this.register(addDisposableDomListener(this.element, 'mousedown', (e: MouseEvent) => this._selectionService!.handleMouseDown(e))); this.register(addDisposableDomListener(this.element, 'mousedown', (e: MouseEvent) => this._selectionService!.handleMouseDown(e)));
@@ -575,7 +583,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
} }
private _createRenderer(): IRenderer { private _createRenderer(): IRenderer {
return this._instantiationService.createInstance(DomRenderer, this, this._document!, this.element!, this.screenElement!, this._viewportElement!, this._helperContainer!, this.linkifier2); return this._instantiationService.createInstance(DomRenderer, this, this._document!, this.element!, this.screenElement!, this._viewportElement!, this._helperContainer!, this.linkifier!);
} }
/** /**
@@ -894,7 +902,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
} }
public registerLinkProvider(linkProvider: ILinkProvider): IDisposable { public registerLinkProvider(linkProvider: ILinkProvider): IDisposable {
return this.linkifier2.registerLinkProvider(linkProvider); return this._linkProviderService.registerLinkProvider(linkProvider);
} }
public registerCharacterJoiner(handler: CharacterJoinerHandler): number { public registerCharacterJoiner(handler: CharacterJoinerHandler): number {
+1 -1
View File
@@ -48,6 +48,7 @@ export class MockTerminal implements ITerminal {
public onRender!: IEvent<{ start: number, end: number }>; public onRender!: IEvent<{ start: number, end: number }>;
public onResize!: IEvent<{ cols: number, rows: number }>; public onResize!: IEvent<{ cols: number, rows: number }>;
public markers!: IMarker[]; public markers!: IMarker[];
public linkifier: ILinkifier2 | undefined;
public coreMouseService!: ICoreMouseService; public coreMouseService!: ICoreMouseService;
public coreService!: ICoreService; public coreService!: ICoreService;
public optionsService!: IOptionsService; public optionsService!: IOptionsService;
@@ -151,7 +152,6 @@ export class MockTerminal implements ITerminal {
} }
public bracketedPasteMode!: boolean; public bracketedPasteMode!: boolean;
public renderer!: IRenderer; public renderer!: IRenderer;
public linkifier2!: ILinkifier2;
public isFocused!: boolean; public isFocused!: boolean;
public options!: Required<ITerminalOptions>; public options!: Required<ITerminalOptions>;
public element!: HTMLElement; public element!: HTMLElement;
+2 -7
View File
@@ -7,7 +7,7 @@ import { IEvent } from 'common/EventEmitter';
import { CharData, IColor, ICoreTerminal, ITerminalOptions } from 'common/Types'; import { CharData, IColor, ICoreTerminal, ITerminalOptions } from 'common/Types';
import { IBuffer } from 'common/buffer/Types'; import { IBuffer } from 'common/buffer/Types';
import { IDisposable, Terminal as ITerminalApi } from '@xterm/xterm'; import { IDisposable, Terminal as ITerminalApi } from '@xterm/xterm';
import { IMouseService, IRenderService } from './services/Services'; import { IMouseService, IRenderService } from 'browser/services/Services';
/** /**
* A portion of the public API that are implemented identially internally and simply passed through. * A portion of the public API that are implemented identially internally and simply passed through.
@@ -18,9 +18,9 @@ export interface ITerminal extends InternalPassthroughApis, ICoreTerminal {
screenElement: HTMLElement | undefined; screenElement: HTMLElement | undefined;
browser: IBrowser; browser: IBrowser;
buffer: IBuffer; buffer: IBuffer;
linkifier: ILinkifier2 | undefined;
viewport: IViewport | undefined; viewport: IViewport | undefined;
options: Required<ITerminalOptions>; options: Required<ITerminalOptions>;
linkifier2: ILinkifier2;
onBlur: IEvent<void>; onBlur: IEvent<void>;
onFocus: IEvent<void>; onFocus: IEvent<void>;
@@ -130,11 +130,6 @@ export interface ILinkifier2 extends IDisposable {
readonly currentLink: ILinkWithState | undefined; readonly currentLink: ILinkWithState | undefined;
attachToDom(element: HTMLElement, mouseService: IMouseService, renderService: IRenderService): void; attachToDom(element: HTMLElement, mouseService: IMouseService, renderService: IRenderService): void;
registerLinkProvider(linkProvider: ILinkProvider): IDisposable;
}
interface ILinkProvider {
provideLinks(y: number, callback: (links: ILink[] | undefined) => void): void;
} }
interface ILink { interface ILink {
@@ -0,0 +1,28 @@
import { ILinkProvider, ILinkProviderService } from 'browser/services/Services';
import { Disposable, toDisposable } from 'common/Lifecycle';
import { IDisposable } from 'common/Types';
export class LinkProviderService extends Disposable implements ILinkProviderService {
declare public serviceBrand: undefined;
public readonly linkProviders: ILinkProvider[] = [];
constructor() {
super();
this.register(toDisposable(() => this.linkProviders.length = 0));
}
public registerLinkProvider(linkProvider: ILinkProvider): IDisposable {
this.linkProviders.push(linkProvider);
return {
dispose: () => {
// Remove the link provider from the list
const providerIndex = this.linkProviders.indexOf(linkProvider);
if (providerIndex !== -1) {
this.linkProviders.splice(providerIndex, 1);
}
}
};
}
}
+12 -1
View File
@@ -5,7 +5,7 @@
import { IEvent } from 'common/EventEmitter'; import { IEvent } from 'common/EventEmitter';
import { IRenderDimensions, IRenderer } from 'browser/renderer/shared/Types'; import { IRenderDimensions, IRenderer } from 'browser/renderer/shared/Types';
import { IColorSet, ReadonlyColorSet } from 'browser/Types'; import { IColorSet, ILink, ReadonlyColorSet } from 'browser/Types';
import { ISelectionRedrawRequestEvent as ISelectionRequestRedrawEvent, ISelectionRequestScrollLinesEvent } from 'browser/selection/Types'; import { ISelectionRedrawRequestEvent as ISelectionRequestRedrawEvent, ISelectionRequestScrollLinesEvent } from 'browser/selection/Types';
import { createDecorator } from 'common/services/ServiceRegistry'; import { createDecorator } from 'common/services/ServiceRegistry';
import { AllColorIndex, IDisposable } from 'common/Types'; import { AllColorIndex, IDisposable } from 'common/Types';
@@ -145,3 +145,14 @@ export interface IThemeService {
*/ */
modifyColors(callback: (colors: IColorSet) => void): void; modifyColors(callback: (colors: IColorSet) => void): void;
} }
export const ILinkProviderService = createDecorator<ILinkProviderService>('LinkProviderService');
export interface ILinkProviderService extends IDisposable {
serviceBrand: undefined;
readonly linkProviders: ReadonlyArray<ILinkProvider>;
registerLinkProvider(linkProvider: ILinkProvider): IDisposable;
}
export interface ILinkProvider {
provideLinks(y: number, callback: (links: ILink[] | undefined) => void): void;
}
+1
View File
@@ -120,6 +120,7 @@ export abstract class CoreTerminal extends Disposable implements ICoreTerminal {
this._oscLinkService = this._instantiationService.createInstance(OscLinkService); this._oscLinkService = this._instantiationService.createInstance(OscLinkService);
this._instantiationService.setService(IOscLinkService, this._oscLinkService); this._instantiationService.setService(IOscLinkService, this._oscLinkService);
// Register input handler and handle/forward events // Register input handler and handle/forward events
this._inputHandler = this.register(new InputHandler(this._bufferService, this._charsetService, this.coreService, this._logService, this.optionsService, this._oscLinkService, this.coreMouseService, this.unicodeService)); this._inputHandler = this.register(new InputHandler(this._bufferService, this._charsetService, this.coreService, this._logService, this.optionsService, this._oscLinkService, this.coreMouseService, this.unicodeService));
this.register(forwardEvent(this._inputHandler.onLineFeed, this._onLineFeed)); this.register(forwardEvent(this._inputHandler.onLineFeed, this._onLineFeed));