remove push/pop/splice calls to BufferLine

src/renderer/CharacterJoinerRegistry.test.ts

@@ -24,14 +24,18 @@ describe('CharacterJoinerRegistry', () => {
     lines.set(4, new BufferLine());
     lines.set(5, lineData([['a', 0x11111111], [' -> b -> c -> '], ['d', 0x22222222]]));
     const line6 = lineData([['wi']]);
-    line6.push([0, '￥', 2, '￥'.charCodeAt(0)]);
-    line6.push([0, '', 0, null]);
+    line6.resize(line6.length + 1, [0, '￥', 2, '￥'.charCodeAt(0)]);
+    line6.resize(line6.length + 1, [0, '', 0, null]);
     let sub = lineData([['deemo']]);
-    for (let i = 0; i < sub.length; ++i) line6.push(sub.get(i));
-    line6.push([0, '\xf0\x9f\x98\x81', 1, 128513]);
-    line6.push([0, ' ', 1, ' '.charCodeAt(0)]);
+    let oldSize = line6.length;
+    line6.resize(oldSize + sub.length, [0, '', 0, 0]);
+    for (let i = 0; i < sub.length; ++i) line6.set(i + oldSize, sub.get(i));
+    line6.resize(line6.length + 1, [0, '\xf0\x9f\x98\x81', 1, 128513]);
+    line6.resize(line6.length + 1, [0, ' ', 1, ' '.charCodeAt(0)]);
     sub = lineData([['jiabc']]);
-    for (let i = 0; i < sub.length; ++i) line6.push(sub.get(i));
+    oldSize = line6.length;
+    line6.resize(oldSize + sub.length, [0, '', 0, 0]);
+    for (let i = 0; i < sub.length; ++i) line6.set(i + oldSize, sub.get(i));
     lines.set(6, line6);
 
     (<MockBuffer>terminal.buffer).setLines(lines);
@@ -264,11 +268,13 @@ describe('CharacterJoinerRegistry', () => {
 type IPartialLineData = ([string] | [string, number]);
 
 function lineData(data: IPartialLineData[]): IBufferLine {
-  const tline = new BufferLine();
+  const tline = new BufferLine(0);
   for (let i = 0; i < data.length; ++i) {
     const line = data[i][0];
     const attr = <number>(data[i][1] || 0);
-    line.split('').map(char => tline.push([attr, char, 1, char.charCodeAt(0)]));
+    const offset = tline.length;
+    tline.resize(tline.length + line.split('').length, [0, '', 0, 0]);
+    line.split('').map((char, idx) => tline.set(idx + offset, [attr, char, 1, char.charCodeAt(0)]));
   }
   return tline;
 }

src/renderer/dom/DomRendererRowFactory.test.ts

@@ -148,9 +148,9 @@ describe('DomRendererRowFactory', () => {
   }
 
   function createEmptyLineData(cols: number): IBufferLine {
-    const lineData = new BufferLine();
+    const lineData = new BufferLine(cols);
     for (let i = 0; i < cols; i++) {
-      lineData.push([DEFAULT_ATTR, NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]);
+      lineData.set(i, [DEFAULT_ATTR, NULL_CELL_CHAR, NULL_CELL_WIDTH, NULL_CELL_CODE]);
     }
     return lineData;
   }