Adjust to use 1-based, note in API

2019-10-17 12:36:03 -07:00
parent 57581ca4ef
commit 8350804858
2 changed files with 5 additions and 3 deletions
@@ -306,7 +306,9 @@ export class Linkifier implements ILinkifier {
      e => {
        this._onLinkTooltip.fire(this._createLinkHoverEvent(x1, y1, x2, y2, fg));
        if (matcher.hoverTooltipCallback) {
-          matcher.hoverTooltipCallback(e, uri, { start: { row: y1, col: x1 }, end: { row: y2, col: x2 } });
+          // Note that IViewportRange use 1-based coordinates to align with escape sequences such
+          // as CUP which use 1,1 as the default for row/col
+          matcher.hoverTooltipCallback(e, uri, { start: { row: y1 + 1, col: x1 + 1 }, end: { row: y2 + 1, col: x2 } });
        }
      },
      () => {