Move logic to helper function

This commit is contained in:
Bruno Ribeito
2018-07-01 22:24:51 +01:00
parent 932a8d5028
commit 7e393dfa8c
+7 -3
View File
@@ -42,9 +42,7 @@ export class SelectionRenderLayer extends BaseRenderLayer {
public onSelectionChanged(terminal: ITerminal, start: [number, number], end: [number, number], columnSelectMode: boolean): void { public onSelectionChanged(terminal: ITerminal, start: [number, number], end: [number, number], columnSelectMode: boolean): void {
// Selection has not changed // Selection has not changed
if (this._areCoordinatesEqual(start, this._state.start) && if (!this._didStateChange(start, end, columnSelectMode)) {
this._areCoordinatesEqual(end, this._state.end) &&
columnSelectMode === this._state.columnSelectMode) {
return; return;
} }
@@ -99,6 +97,12 @@ export class SelectionRenderLayer extends BaseRenderLayer {
this._state.columnSelectMode = columnSelectMode; this._state.columnSelectMode = columnSelectMode;
} }
private _didStateChange(start: [number, number], end: [number, number], columnSelectMode: boolean): boolean {
return !this._areCoordinatesEqual(start, this._state.start) ||
!this._areCoordinatesEqual(end, this._state.end) ||
columnSelectMode !== this._state.columnSelectMode;
}
private _areCoordinatesEqual(coord1: [number, number], coord2: [number, number]): boolean { private _areCoordinatesEqual(coord1: [number, number], coord2: [number, number]): boolean {
if (!coord1 || !coord2) { if (!coord1 || !coord2) {
return false; return false;