Only wrap single width unicode chars

This commit is contained in:
Daniel Imms
2017-05-14 12:20:01 -07:00
parent 508d3ab68c
commit 6c8949bba1
+23 -33
View File
@@ -283,41 +283,31 @@ export class Renderer {
} }
} }
// TODO: Consider performance implications of not pulling these from the pool
if (ch_width === 2) { if (ch_width === 2) {
innerHTML += '<span class="xterm-wide-char">'; // Wrap wide characters so they're sized correctly
innerHTML += `<span class="xterm-wide-char">${ch}</span>`;
} else if (ch.charCodeAt(0) > 255) {
// Wrap any non-wide unicode character as some fonts size them badly
innerHTML += `<span class="xterm-normal-char">${ch}</span>`;
} else { } else {
// TODO: Only wrap unicode characters that may vary in width switch (ch) {
innerHTML += '<span class="xterm-normal-char">'; case '&':
} innerHTML += '&amp;';
switch (ch) { break;
case '&': case '<':
innerHTML += '&amp;'; innerHTML += '&lt;';
//out += '&amp;'; break;
break; case '>':
case '<': innerHTML += '&gt;';
innerHTML += '&lt;'; break;
//out += '&lt;'; default:
break; if (ch <= ' ') {
case '>': innerHTML += '&nbsp;';
innerHTML += '&gt;'; } else {
//out += '&gt;'; innerHTML += ch;
break; }
default: break;
if (ch <= ' ') { }
innerHTML += '&nbsp;';
//out += '&nbsp;';
} else {
innerHTML += ch;
// out += ch;
}
break;
}
if (ch_width === 2) {
innerHTML += '</span>';
} else {
// TODO: Only wrap unicode characters that may vary in width
innerHTML += '</span>';
} }
attr = data; attr = data;