Quick fix to prevent terminal scrolling when user is looking into scrollback.

This commit is contained in:
Mikko Karvonen
2016-10-25 13:54:57 +03:00
parent 8feaacf57e
commit 5e68acfc76
+20 -7
View File
@@ -231,6 +231,9 @@ function Terminal(options) {
this.tabs; this.tabs;
this.setupStops(); this.setupStops();
// Store if user went browsing history in scrollback
this.userScrolling = false;
} }
inherits(Terminal, EventEmitter); inherits(Terminal, EventEmitter);
@@ -1250,7 +1253,9 @@ Terminal.prototype.scroll = function() {
this.lines = this.lines.slice(-(this.ybase + this.rows) + 1); this.lines = this.lines.slice(-(this.ybase + this.rows) + 1);
} }
this.ydisp = this.ybase; if (!this.userScrolling) {
this.ydisp = this.ybase;
}
// last line // last line
row = this.ybase + this.rows - 1; row = this.ybase + this.rows - 1;
@@ -1272,7 +1277,9 @@ Terminal.prototype.scroll = function() {
if (this.scrollTop !== 0) { if (this.scrollTop !== 0) {
if (this.ybase !== 0) { if (this.ybase !== 0) {
this.ybase--; this.ybase--;
this.ydisp = this.ybase; if (!this.userScrolling) {
this.ydisp = this.ybase;
}
} }
this.lines.splice(this.ybase + this.scrollTop, 1); this.lines.splice(this.ybase + this.scrollTop, 1);
} }
@@ -1292,6 +1299,12 @@ Terminal.prototype.scroll = function() {
* viewport originally. * viewport originally.
*/ */
Terminal.prototype.scrollDisp = function(disp, suppressScrollEvent) { Terminal.prototype.scrollDisp = function(disp, suppressScrollEvent) {
if (disp < 0) {
this.userScrolling = true;
} else if (disp + this.ydisp >= this.ybase) {
this.userScrolling = false;
}
this.ydisp += disp; this.ydisp += disp;
if (this.ydisp > this.ybase) { if (this.ydisp > this.ybase) {
@@ -1339,11 +1352,11 @@ Terminal.prototype.write = function(data) {
this.refreshStart = this.y; this.refreshStart = this.y;
this.refreshEnd = this.y; this.refreshEnd = this.y;
if (this.ybase !== this.ydisp) { // if (this.ybase !== this.ydisp) {
this.ydisp = this.ybase; // this.ydisp = this.ybase;
this.emit('scroll', this.ydisp); // this.emit('scroll', this.ydisp);
this.maxRange(); // this.maxRange();
} // }
// apply leftover surrogate high from last write // apply leftover surrogate high from last write
if (this.surrogate_high) { if (this.surrogate_high) {