Merge pull request #4293 from Tyriar/4292
Log a warning if task queues exceed deadline by 20ms
This commit is contained in:
+10
-1
@@ -66,6 +66,8 @@ abstract class TaskQueue implements ITaskQueue {
|
|||||||
this._idleCallback = undefined;
|
this._idleCallback = undefined;
|
||||||
let taskDuration = 0;
|
let taskDuration = 0;
|
||||||
let longestTask = 0;
|
let longestTask = 0;
|
||||||
|
let lastDeadlineRemaining = deadline.timeRemaining();
|
||||||
|
let deadlineRemaining = 0;
|
||||||
while (this._i < this._tasks.length) {
|
while (this._i < this._tasks.length) {
|
||||||
taskDuration = performance.now();
|
taskDuration = performance.now();
|
||||||
this._tasks[this._i++]();
|
this._tasks[this._i++]();
|
||||||
@@ -73,10 +75,17 @@ abstract class TaskQueue implements ITaskQueue {
|
|||||||
longestTask = Math.max(taskDuration, longestTask);
|
longestTask = Math.max(taskDuration, longestTask);
|
||||||
// Guess the following task will take a similar time to the longest task in this batch, allow
|
// Guess the following task will take a similar time to the longest task in this batch, allow
|
||||||
// additional room to try avoid exceeding the deadline
|
// additional room to try avoid exceeding the deadline
|
||||||
if (longestTask * 1.5 > deadline.timeRemaining()) {
|
deadlineRemaining = deadline.timeRemaining();
|
||||||
|
if (longestTask * 1.5 > deadlineRemaining) {
|
||||||
|
// Warn when the time exceeding the deadline is over 20ms, if this happens in practice the
|
||||||
|
// task should be split into sub-tasks to ensure the UI remains responsive.
|
||||||
|
if (lastDeadlineRemaining - taskDuration < -20) {
|
||||||
|
console.warn(`task queue exceeded allotted deadline by ${Math.abs(Math.round(lastDeadlineRemaining - taskDuration))}ms`);
|
||||||
|
}
|
||||||
this._start();
|
this._start();
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
lastDeadlineRemaining = deadlineRemaining;
|
||||||
}
|
}
|
||||||
this.clear();
|
this.clear();
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user