Resolve TODOs
This commit is contained in:
@@ -14,8 +14,6 @@ export abstract class BaseRenderLayer implements IRenderLayer {
|
||||
private scaledLineHeight: number;
|
||||
private scaledLineDrawY: number;
|
||||
|
||||
// TODO: This should be shared between terminals, but not for static as some
|
||||
// terminals may have different styles
|
||||
private _charAtlas: HTMLCanvasElement | ImageBitmap;
|
||||
|
||||
constructor(
|
||||
@@ -32,7 +30,6 @@ export abstract class BaseRenderLayer implements IRenderLayer {
|
||||
container.appendChild(this._canvas);
|
||||
}
|
||||
|
||||
// TODO: Should this do anything?
|
||||
public onOptionsChanged(terminal: ITerminal): void {}
|
||||
public onBlur(terminal: ITerminal): void {}
|
||||
public onFocus(terminal: ITerminal): void {}
|
||||
|
||||
@@ -33,13 +33,13 @@ export class Renderer implements IRenderer {
|
||||
|
||||
public setTheme(theme: ITheme): IColorSet {
|
||||
this._colorManager.setTheme(theme);
|
||||
|
||||
// Clear layers and force a full render
|
||||
this._renderLayers.forEach(l => {
|
||||
l.onThemeChanged(this._terminal, this._colorManager.colors);
|
||||
l.reset(this._terminal);
|
||||
});
|
||||
|
||||
// TODO: This is currently done for every single terminal, but it's static so it's wasting time
|
||||
this._terminal.refresh(0, this._terminal.rows - 1);
|
||||
|
||||
return this._colorManager.colors;
|
||||
|
||||
Reference in New Issue
Block a user