Resolve TODOs

This commit is contained in:
Daniel Imms
2017-09-04 14:13:41 -07:00
parent 0dc24cf800
commit 46b0857ef6
3 changed files with 6 additions and 6 deletions
-3
View File
@@ -14,8 +14,6 @@ export abstract class BaseRenderLayer implements IRenderLayer {
private scaledLineHeight: number;
private scaledLineDrawY: number;
// TODO: This should be shared between terminals, but not for static as some
// terminals may have different styles
private _charAtlas: HTMLCanvasElement | ImageBitmap;
constructor(
@@ -32,7 +30,6 @@ export abstract class BaseRenderLayer implements IRenderLayer {
container.appendChild(this._canvas);
}
// TODO: Should this do anything?
public onOptionsChanged(terminal: ITerminal): void {}
public onBlur(terminal: ITerminal): void {}
public onFocus(terminal: ITerminal): void {}
+1 -1
View File
@@ -33,13 +33,13 @@ export class Renderer implements IRenderer {
public setTheme(theme: ITheme): IColorSet {
this._colorManager.setTheme(theme);
// Clear layers and force a full render
this._renderLayers.forEach(l => {
l.onThemeChanged(this._terminal, this._colorManager.colors);
l.reset(this._terminal);
});
// TODO: This is currently done for every single terminal, but it's static so it's wasting time
this._terminal.refresh(0, this._terminal.rows - 1);
return this._colorManager.colors;