Merge pull request #1017 from Tyriar/1015_fix_emoji_selection

Fix several issues related to emojis
2017-10-06 09:23:03 -07:00
parent 265057a716 29be4f6a92
commit 3c2614ade7
4 changed files with 210 additions and 23 deletions
@@ -193,10 +193,15 @@ export class TextRenderLayer extends BaseRenderLayer {
  }

 	/**
-	 * Whether a character is overlapping to the
-	 * next cell.
+	 * Whether a character is overlapping to the next cell.
 	 */
  private _isOverlapping(charData: CharData): boolean {
+    // Only single cell characters can be overlapping, rendering issues can
+    // occur without this check
+    if (charData[CHAR_DATA_WIDTH_INDEX] !== 1) {
+      return false;
+    }
+
    // We assume that any ascii character will not overlap
    const code = charData[CHAR_DATA_CODE_INDEX];
    if (code < 256) {