Optimize _clipImageData

This makes clip image data around twice as fast, it's a little tricky to
measure it though. Changes:

- Work on Uint32Array instead of Uint8 so it's 1 assignment per pixel
  instead of 1 per channel.
- Perform the clipping in-place using the original image data to avoid
  allocation a new buffer.

Fixes #4197
This commit is contained in:
Daniel Imms
2022-10-12 10:16:26 -07:00
parent 1b13127f0b
commit 28fcffe46c
+14 -10
View File
@@ -770,20 +770,24 @@ export class TextureAtlas implements ITextureAtlas {
} }
private _clipImageData(imageData: ImageData, boundingBox: IBoundingBox): ImageData { private _clipImageData(imageData: ImageData, boundingBox: IBoundingBox): ImageData {
// Operate on pixels instead of channels to reduce the amount of work
const originalData = new Uint32Array(imageData.data.buffer);
// Create a new view on the same buffer for the clipped data. The clipping operation is done in
// place to avoid allocating another buffer
const width = boundingBox.right - boundingBox.left + 1; const width = boundingBox.right - boundingBox.left + 1;
const height = boundingBox.bottom - boundingBox.top + 1; const height = boundingBox.bottom - boundingBox.top + 1;
const clippedData = new Uint8ClampedArray(width * height * 4); const clippedData = new Uint32Array(imageData.data.buffer, 0, width * height);
for (let y = boundingBox.top; y <= boundingBox.bottom; y++) {
for (let x = boundingBox.left; x <= boundingBox.right; x++) { // Perform clipping and return the result
const oldOffset = y * this._tmpCanvas.width * 4 + x * 4; let x = 0;
const newOffset = (y - boundingBox.top) * width * 4 + (x - boundingBox.left) * 4; let y = 0;
clippedData[newOffset] = imageData.data[oldOffset]; for (y = boundingBox.top; y <= boundingBox.bottom; y++) {
clippedData[newOffset + 1] = imageData.data[oldOffset + 1]; for (x = boundingBox.left; x <= boundingBox.right; x++) {
clippedData[newOffset + 2] = imageData.data[oldOffset + 2]; clippedData[(y - boundingBox.top) * width + (x - boundingBox.left)] = originalData[y * imageData.width + x];
clippedData[newOffset + 3] = imageData.data[oldOffset + 3];
} }
} }
return new ImageData(clippedData, width, height); return new ImageData(new Uint8ClampedArray(clippedData.buffer, clippedData.byteOffset, clippedData.byteLength), width, height);
} }
} }