Make all emitters readonly

src/browser/Linkifier2.ts

@@ -26,9 +26,9 @@ export class Linkifier2 extends Disposable implements ILinkifier2 {
   private _activeProviderReplies: Map<Number, ILinkWithState[] | undefined> | undefined;
   private _activeLine: number = -1;
 
-  private _onShowLinkUnderline = this.register(new EventEmitter<ILinkifierEvent>());
+  private readonly _onShowLinkUnderline = this.register(new EventEmitter<ILinkifierEvent>());
   public readonly onShowLinkUnderline = this._onShowLinkUnderline.event;
-  private _onHideLinkUnderline = this.register(new EventEmitter<ILinkifierEvent>());
+  private readonly _onHideLinkUnderline = this.register(new EventEmitter<ILinkifierEvent>());
   public readonly onHideLinkUnderline = this._onHideLinkUnderline.event;
 
   constructor(

src/browser/Terminal.ts

@@ -122,26 +122,26 @@ export class Terminal extends CoreTerminal implements ITerminal {
   private _colorManager: ColorManager | undefined;
   private _theme: ITheme | undefined;
 
-  private _onCursorMove = new EventEmitter<void>();
+  private readonly _onCursorMove = new EventEmitter<void>();
   public readonly onCursorMove = this._onCursorMove.event;
-  private _onKey = new EventEmitter<{ key: string, domEvent: KeyboardEvent }>();
+  private readonly _onKey = new EventEmitter<{ key: string, domEvent: KeyboardEvent }>();
   public readonly onKey = this._onKey.event;
-  private _onRender = new EventEmitter<{ start: number, end: number }>();
+  private readonly _onRender = new EventEmitter<{ start: number, end: number }>();
   public readonly onRender = this._onRender.event;
-  private _onSelectionChange = new EventEmitter<void>();
+  private readonly _onSelectionChange = new EventEmitter<void>();
   public readonly onSelectionChange = this._onSelectionChange.event;
-  private _onTitleChange = new EventEmitter<string>();
+  private readonly _onTitleChange = new EventEmitter<string>();
   public readonly onTitleChange = this._onTitleChange.event;
-  private _onBell = new EventEmitter<void>();
+  private readonly _onBell = new EventEmitter<void>();
   public readonly onBell = this._onBell.event;
 
-  private _onFocus = new EventEmitter<void>();
+  private readonly _onFocus = new EventEmitter<void>();
   public readonly onFocus = this._onFocus.event;
-  private _onBlur = new EventEmitter<void>();
+  private readonly _onBlur = new EventEmitter<void>();
   public readonly onBlur = this._onBlur.event;
-  private _onA11yCharEmitter = new EventEmitter<string>();
+  private readonly _onA11yCharEmitter = new EventEmitter<string>();
   public readonly onA11yChar = this._onA11yCharEmitter.event;
-  private _onA11yTabEmitter = new EventEmitter<number>();
+  private readonly _onA11yTabEmitter = new EventEmitter<number>();
   public readonly onA11yTab = this._onA11yTabEmitter.event;
 
   /**

src/browser/services/CharSizeService.ts

@@ -16,7 +16,7 @@ export class CharSizeService implements ICharSizeService {
 
   public get hasValidSize(): boolean { return this.width > 0 && this.height > 0; }
 
-  private _onCharSizeChange = new EventEmitter<void>();
+  private readonly _onCharSizeChange = new EventEmitter<void>();
   public readonly onCharSizeChange = this._onCharSizeChange.event;
 
   constructor(

src/browser/services/RenderService.ts

@@ -39,13 +39,13 @@ export class RenderService extends Disposable implements IRenderService {
     columnSelectMode: false
   };
 
-  private _onDimensionsChange = new EventEmitter<IRenderDimensions>();
+  private readonly _onDimensionsChange = new EventEmitter<IRenderDimensions>();
   public readonly onDimensionsChange =  this._onDimensionsChange.event;
-  private _onRenderedViewportChange = new EventEmitter<{ start: number, end: number }>();
+  private readonly _onRenderedViewportChange = new EventEmitter<{ start: number, end: number }>();
   public readonly onRenderedViewportChange = this._onRenderedViewportChange.event;
-  private _onRender = new EventEmitter<{ start: number, end: number }>();
+  private readonly _onRender = new EventEmitter<{ start: number, end: number }>();
   public readonly onRender = this._onRender.event;
-  private _onRefreshRequest = new EventEmitter<{ start: number, end: number }>();
+  private readonly _onRefreshRequest = new EventEmitter<{ start: number, end: number }>();
   public readonly onRefreshRequest = this._onRefreshRequest.event;
 
   public get dimensions(): IRenderDimensions { return this._renderer.dimensions; }

src/browser/services/SelectionService.ts

@@ -111,13 +111,13 @@ export class SelectionService extends Disposable implements ISelectionService {
   private _oldSelectionStart: [number, number] | undefined = undefined;
   private _oldSelectionEnd: [number, number] | undefined = undefined;
 
-  private _onLinuxMouseSelection = this.register(new EventEmitter<string>());
+  private readonly _onLinuxMouseSelection = this.register(new EventEmitter<string>());
   public readonly onLinuxMouseSelection = this._onLinuxMouseSelection.event;
-  private _onRedrawRequest = this.register(new EventEmitter<ISelectionRedrawRequestEvent>());
+  private readonly _onRedrawRequest = this.register(new EventEmitter<ISelectionRedrawRequestEvent>());
   public readonly onRequestRedraw = this._onRedrawRequest.event;
-  private _onSelectionChange = this.register(new EventEmitter<void>());
+  private readonly _onSelectionChange = this.register(new EventEmitter<void>());
   public readonly onSelectionChange = this._onSelectionChange.event;
-  private _onRequestScrollLines = this.register(new EventEmitter<ISelectionRequestScrollLinesEvent>());
+  private readonly _onRequestScrollLines = this.register(new EventEmitter<ISelectionRequestScrollLinesEvent>());
   public readonly onRequestScrollLines = this._onRequestScrollLines.event;
 
   constructor(