Introduce removeElementFromParent helper

This commit is contained in:
Daniel Imms
2020-06-04 07:20:59 -07:00
parent fb25be3ecd
commit 15f1759580
4 changed files with 17 additions and 9 deletions
+3 -4
View File
@@ -12,6 +12,7 @@ import { addDisposableDomListener } from 'browser/Lifecycle';
import { Disposable } from 'common/Lifecycle';
import { ScreenDprMonitor } from 'browser/ScreenDprMonitor';
import { IRenderService } from 'browser/services/Services';
import { removeElementFromParent } from 'browser/Dom';
const MAX_ROWS_TO_READ = 20;
@@ -106,7 +107,7 @@ export class AccessibilityManager extends Disposable {
public dispose(): void {
super.dispose();
this._terminal.element?.removeChild(this._accessibilityTreeRoot);
removeElementFromParent(this._accessibilityTreeRoot);
this._rowElements.length = 0;
}
@@ -240,9 +241,7 @@ export class AccessibilityManager extends Disposable {
// Only detach/attach on mac as otherwise messages can go unaccounced
if (isMac) {
if (this._liveRegion.parentNode) {
this._accessibilityTreeRoot.removeChild(this._liveRegion);
}
removeElementFromParent(this._liveRegion);
}
}