Remove blankLine localized string
Using a nbsp is more correct and lets the screen reader handle how it wants Fixes #2260
This commit is contained in:
@@ -258,7 +258,11 @@ export class AccessibilityManager extends Disposable {
|
|||||||
const posInSet = (buffer.ydisp + i + 1).toString();
|
const posInSet = (buffer.ydisp + i + 1).toString();
|
||||||
const element = this._rowElements[i];
|
const element = this._rowElements[i];
|
||||||
if (element) {
|
if (element) {
|
||||||
element.textContent = lineData.length === 0 ? Strings.blankLine : lineData;
|
if (lineData.length === 0) {
|
||||||
|
element.innerHTML = ' ';
|
||||||
|
} else {
|
||||||
|
element.textContent = lineData;
|
||||||
|
}
|
||||||
element.setAttribute('aria-posinset', posInSet);
|
element.setAttribute('aria-posinset', posInSet);
|
||||||
element.setAttribute('aria-setsize', setSize);
|
element.setAttribute('aria-setsize', setSize);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -3,6 +3,5 @@
|
|||||||
* @license MIT
|
* @license MIT
|
||||||
*/
|
*/
|
||||||
|
|
||||||
export let blankLine = 'Blank line';
|
|
||||||
export let promptLabel = 'Terminal input';
|
export let promptLabel = 'Terminal input';
|
||||||
export let tooMuchOutput = 'Too much output to announce, navigate to rows manually to read';
|
export let tooMuchOutput = 'Too much output to announce, navigate to rows manually to read';
|
||||||
|
|||||||
Vendored
-5
@@ -316,11 +316,6 @@ declare module 'xterm' {
|
|||||||
* The set of localizable strings.
|
* The set of localizable strings.
|
||||||
*/
|
*/
|
||||||
export interface ILocalizableStrings {
|
export interface ILocalizableStrings {
|
||||||
/**
|
|
||||||
* Announcement for a blank line when `screenReaderMode` is enabled.
|
|
||||||
*/
|
|
||||||
blankLine: string;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The aria label for the underlying input textarea for the terminal.
|
* The aria label for the underlying input textarea for the terminal.
|
||||||
*/
|
*/
|
||||||
|
|||||||
Reference in New Issue
Block a user