feat: add CopyObject and DeleteObjects operations
Implements object manipulation capabilities for v0.11.0: - CopyObject: server-side copy within/across buckets with metadata control - DeleteObjects: batch delete up to 1000 objects in single request Both operations follow AWS S3 API specification with proper: - AWS Signature V4 signing - XML request/response handling - Content-MD5 and SHA256 headers - Comprehensive input validation Fixed DeleteObjects signature mismatch with MinIO by correcting the canonical query string format for empty query parameter values (delete= instead of delete). The writeQuery function now properly appends = to keys with empty values per AWS Signature V4 specification. CopyObject enables CLI mv commands. DeleteObjects enables efficient batch operations for CLI sync/rm. Tests: All CopyObject and DeleteObjects tests passing with MinIO. "lets work on the object level operations"
This commit is contained in:
Rohan Verma
+205
@@ -2,9 +2,12 @@ package simples3
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"fmt"
|
||||
"io"
|
||||
"os"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
func TestS3_FileUploadPostAndPut(t *testing.T) {
|
||||
@@ -379,3 +382,205 @@ func TestS3_FileDelete(t *testing.T) {
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestCopyObject(t *testing.T) {
|
||||
s3 := setupTestS3(t)
|
||||
testBucket := os.Getenv("AWS_S3_BUCKET")
|
||||
|
||||
// Setup: upload source file
|
||||
sourceKey := fmt.Sprintf("test-copy-source-%d.txt", time.Now().Unix())
|
||||
destKey := fmt.Sprintf("test-copy-dest-%d.txt", time.Now().Unix())
|
||||
|
||||
_, err := s3.FilePut(UploadInput{
|
||||
Bucket: testBucket,
|
||||
ObjectKey: sourceKey,
|
||||
ContentType: "text/plain",
|
||||
Body: strings.NewReader("test content for copy"),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Failed to upload source file: %v", err)
|
||||
}
|
||||
|
||||
defer func() {
|
||||
s3.FileDelete(DeleteInput{Bucket: testBucket, ObjectKey: sourceKey})
|
||||
s3.FileDelete(DeleteInput{Bucket: testBucket, ObjectKey: destKey})
|
||||
}()
|
||||
|
||||
t.Run("CopyWithinBucket", func(t *testing.T) {
|
||||
output, err := s3.CopyObject(CopyObjectInput{
|
||||
SourceBucket: testBucket,
|
||||
SourceKey: sourceKey,
|
||||
DestBucket: testBucket,
|
||||
DestKey: destKey,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("CopyObject failed: %v", err)
|
||||
}
|
||||
if output.ETag == "" {
|
||||
t.Error("Expected non-empty ETag")
|
||||
}
|
||||
t.Logf("Copied to %s, ETag: %s, LastModified: %s", destKey, output.ETag, output.LastModified)
|
||||
})
|
||||
|
||||
t.Run("VerifyCopiedObject", func(t *testing.T) {
|
||||
details, err := s3.FileDetails(DetailsInput{
|
||||
Bucket: testBucket,
|
||||
ObjectKey: destKey,
|
||||
})
|
||||
if err != nil {
|
||||
t.Errorf("Copied object not found: %v", err)
|
||||
return
|
||||
}
|
||||
t.Logf("Copied object details: size=%s, type=%s", details.ContentLength, details.ContentType)
|
||||
|
||||
// Verify content matches
|
||||
body, err := s3.FileDownload(DownloadInput{
|
||||
Bucket: testBucket,
|
||||
ObjectKey: destKey,
|
||||
})
|
||||
if err != nil {
|
||||
t.Errorf("Failed to download copied object: %v", err)
|
||||
return
|
||||
}
|
||||
defer body.Close()
|
||||
|
||||
content, err := io.ReadAll(body)
|
||||
if err != nil {
|
||||
t.Errorf("Failed to read copied object: %v", err)
|
||||
return
|
||||
}
|
||||
|
||||
if string(content) != "test content for copy" {
|
||||
t.Errorf("Copied content mismatch: got %q, want %q", string(content), "test content for copy")
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func TestCopyObject_EmptySource(t *testing.T) {
|
||||
s3 := setupTestS3(t)
|
||||
|
||||
_, err := s3.CopyObject(CopyObjectInput{
|
||||
SourceBucket: "",
|
||||
SourceKey: "",
|
||||
DestBucket: "dest",
|
||||
DestKey: "key",
|
||||
})
|
||||
if err == nil {
|
||||
t.Error("Expected error for empty source bucket and key")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "source bucket and key are required") {
|
||||
t.Errorf("Expected 'source bucket and key are required' error, got: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCopyObject_EmptyDest(t *testing.T) {
|
||||
s3 := setupTestS3(t)
|
||||
|
||||
_, err := s3.CopyObject(CopyObjectInput{
|
||||
SourceBucket: "source",
|
||||
SourceKey: "key",
|
||||
DestBucket: "",
|
||||
DestKey: "",
|
||||
})
|
||||
if err == nil {
|
||||
t.Error("Expected error for empty destination bucket and key")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "destination bucket and key are required") {
|
||||
t.Errorf("Expected 'destination bucket and key are required' error, got: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestDeleteObjects(t *testing.T) {
|
||||
s3 := setupTestS3(t)
|
||||
testBucket := os.Getenv("AWS_S3_BUCKET")
|
||||
timestamp := time.Now().Unix()
|
||||
|
||||
// Setup: upload multiple files
|
||||
keys := []string{
|
||||
fmt.Sprintf("batch-delete-%d-1.txt", timestamp),
|
||||
fmt.Sprintf("batch-delete-%d-2.txt", timestamp),
|
||||
fmt.Sprintf("batch-delete-%d-3.txt", timestamp),
|
||||
}
|
||||
|
||||
for _, key := range keys {
|
||||
_, err := s3.FilePut(UploadInput{
|
||||
Bucket: testBucket,
|
||||
ObjectKey: key,
|
||||
ContentType: "text/plain",
|
||||
Body: strings.NewReader("test"),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Failed to upload %s: %v", key, err)
|
||||
}
|
||||
}
|
||||
|
||||
t.Run("DeleteMultiple", func(t *testing.T) {
|
||||
output, err := s3.DeleteObjects(DeleteObjectsInput{
|
||||
Bucket: testBucket,
|
||||
Objects: keys,
|
||||
Quiet: false,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("DeleteObjects failed: %v", err)
|
||||
}
|
||||
|
||||
if len(output.Deleted) != len(keys) {
|
||||
t.Errorf("Expected %d deleted, got %d", len(keys), len(output.Deleted))
|
||||
}
|
||||
if len(output.Errors) > 0 {
|
||||
t.Errorf("Unexpected errors: %+v", output.Errors)
|
||||
}
|
||||
t.Logf("Successfully deleted %d objects", len(output.Deleted))
|
||||
for _, deleted := range output.Deleted {
|
||||
t.Logf(" - Deleted: %s", deleted.Key)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func TestDeleteObjects_Validation(t *testing.T) {
|
||||
s3 := setupTestS3(t)
|
||||
|
||||
t.Run("EmptyBucket", func(t *testing.T) {
|
||||
_, err := s3.DeleteObjects(DeleteObjectsInput{
|
||||
Bucket: "",
|
||||
Objects: []string{"key"},
|
||||
})
|
||||
if err == nil {
|
||||
t.Error("Expected error for empty bucket")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "bucket name is required") {
|
||||
t.Errorf("Expected 'bucket name is required' error, got: %v", err)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("EmptyObjects", func(t *testing.T) {
|
||||
_, err := s3.DeleteObjects(DeleteObjectsInput{
|
||||
Bucket: "bucket",
|
||||
Objects: []string{},
|
||||
})
|
||||
if err == nil {
|
||||
t.Error("Expected error for empty objects")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "at least one object key is required") {
|
||||
t.Errorf("Expected 'at least one object key is required' error, got: %v", err)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("TooManyObjects", func(t *testing.T) {
|
||||
keys := make([]string, 1001)
|
||||
for i := range keys {
|
||||
keys[i] = fmt.Sprintf("key-%d", i)
|
||||
}
|
||||
|
||||
_, err := s3.DeleteObjects(DeleteObjectsInput{
|
||||
Bucket: "bucket",
|
||||
Objects: keys,
|
||||
})
|
||||
if err == nil {
|
||||
t.Error("Expected error for >1000 objects")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "cannot delete more than 1000 objects per request") {
|
||||
t.Errorf("Expected '1000 objects' error, got: %v", err)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user