Mark Severson f18420efc3 x/crypto/ssh/agent: Fix keyring removing the wrong key(s) ...

The Remove method for the keyring sliced the internal keys list
incorrectly when removing a key. This caused the wrong key to be removed
or sometimes multiple keys were removed. Additionally, if the key to be
removed was the last key, the method never returned.

Fixes golang/go#13628

Change-Id: I0facbcb8f8b65709222067ce37ea26e3fb5ba8e8
Reviewed-on: https://go-review.googlesource.com/17870
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

2015-12-15 19:15:01 +00:00

..

agent

x/crypto/ssh/agent: Fix keyring removing the wrong key(s)

2015-12-15 19:15:01 +00:00

terminal

ssh/terminal: fix SetSize when nothing on current line

2014-12-19 22:48:49 +00:00

test

x/crypto/ssh/test: test all key exchanges against sshd.

2015-08-17 21:45:12 +00:00

testdata

crypto/ssh: update references to the old code.google.com repo

2015-04-22 11:59:31 +00:00

benchmark_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

certs_test.go

ssh: fix flake in TestHostKeyCert

2015-08-02 23:53:45 +00:00

certs.go

ssh: Add explicit type in comparison with constant to make go-fuzz happy

2015-06-22 23:34:07 +00:00

channel.go

go.crypto/ssh: reuse packet buffer for channel writes.

2014-09-16 12:30:05 -07:00

cipher_test.go

crypto/ssh: fix format string error in test.

2015-06-08 19:52:49 +00:00

cipher.go

x/crypto/ssh: add padding oracle countermeasures for AES-CBC.

2015-05-30 19:27:53 +00:00

client_auth_test.go

crypto/ssh: clearer error messages when "no ciphers in common"

2015-08-29 19:16:37 +00:00

client_auth.go

go.crypto/ssh: fix authentication after all public keys are rejected by a server.

2014-05-13 10:51:53 -07:00

client_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

client.go

crypto/ssh: allow client to specify host key algorithms.

2015-08-04 13:06:53 +00:00

common.go

crypto/ssh: clearer error messages when "no ciphers in common"

2015-08-29 19:16:37 +00:00

connection.go

x/crypto/ssh: fix comment

2015-07-06 16:48:17 +00:00

doc.go

crypto/ssh: fix the links to the SSH protocol documents

2015-04-16 17:18:06 +00:00

example_test.go

ssh: make godoc examples easier to reuse

2015-02-02 06:42:08 +00:00

handshake_test.go

crypto/ssh: fix deadlock during error condition.

2015-08-17 22:20:11 +00:00

handshake.go

crypto/ssh: clearer error messages when "no ciphers in common"

2015-08-29 19:16:37 +00:00

kex_test.go

x/crypto/ssh: close memPipe after running kex test.

2015-08-17 22:17:06 +00:00

kex.go

x/crypto/ssh: run go fmt

2015-12-01 00:25:08 +00:00

keys_test.go

crypto/ssh: Support turning a crypto.Signer into an ssh.Signer

2015-09-24 18:35:42 +00:00

keys.go

crypto/ssh: Support turning a crypto.Signer into an ssh.Signer

2015-09-24 18:35:42 +00:00

mac.go

ssh: add hmac-sha2-256.

2015-05-14 18:39:32 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: fix bounds check in parseString

2015-06-27 22:03:05 +00:00

messages.go

x/crypto/ssh: fix bounds check in parseString

2015-06-27 22:03:05 +00:00

mux_test.go

go.crypto/ssh: reuse packet buffer for channel writes.

2014-09-16 12:30:05 -07:00

mux.go

go.crypto/ssh: only offset channel IDs when debugMux is

2014-04-14 09:23:18 -07:00

server.go

x/crypto/ssh: Add protocol version to ServerVersion

2015-09-28 22:51:19 +00:00

session_test.go

crypto/ssh: allow client to specify host key algorithms.

2015-08-04 13:06:53 +00:00

session.go

crypto/ssh: fix typo in error string.

2015-11-15 23:11:30 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

crypto/ssh: Handle error in dial to avoid a goroutine leak

2015-08-08 08:51:02 +00:00

testdata_test.go

go.crypto: use golang.org/x/... import paths

2014-11-10 08:50:25 +11:00

transport_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

transport.go

crypto/ssh: add support for aes128-cbc cipher.

2015-04-10 21:42:31 +00:00