Damien Miller 593c81af8a ssh: correctly ignore pre-banner lines ...

Reading the peer's benner in readVersion() was incorrectly counting
lines sent by the server before the actual `SSH-2.0` banner against
the line limit for the banner itself.

This is incorrect per RFC 4253 section 4.2, where the limit of 255
characters is written to apply only to the `SSH-` banner string
itself.

This instead limits pre-banner lines to 255 characters each but
instead allows a maximum of 1024 lines.

Change-Id: Ief014bb3413e26e8d2077d3eb204ceaea9dc9444
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/811320
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>

2026-08-17 08:34:06 -07:00

..

agent

all: clean up minor issues found by staticcheck

2026-07-21 14:30:59 -07:00

internal/bcrypt_pbkdf

…

knownhosts

ssh/knownhosts: reject lines with multiple or unknown markers

2026-06-02 00:24:36 -07:00

terminal

…

test

ssh/test: isolate CLI tests from user SSH config and agent

2026-06-02 00:25:33 -07:00

testdata

…

benchmark_test.go

…

buffer_test.go

all: clean up minor issues found by staticcheck

2026-07-21 14:30:59 -07:00

buffer.go

…

certs_test.go

ssh: reject certificate signature keys before recursing

2026-07-22 10:37:06 -07:00

certs.go

ssh: reject certificate signature keys before recursing

2026-07-22 10:37:06 -07:00

channel_test.go

ssh: return window credit for discarded extended data

2026-08-03 14:00:09 -07:00

channel.go

ssh: return window credit for discarded extended data

2026-08-03 14:00:09 -07:00

cipher_test.go

…

cipher.go

ssh: fix incorrect operator order

2026-05-21 17:03:25 -07:00

client_auth_test.go

ssh: don't close the connection on an unparseable public key

2026-07-13 12:20:29 -07:00

client_auth.go

ssh: sanitize various error messages

2026-07-13 12:23:17 -07:00

client_test.go

…

client.go

ssh: add openssh controlmaster socket support

2026-05-21 19:39:36 -07:00

common_test.go

…

common.go

ssh: permit empty but non-nil HostKeyAlgorithms, KeyExchanges, Ciphers, MACs

2026-07-22 10:37:01 -07:00

connection.go

ssh: sanitize various error messages

2026-07-13 12:23:17 -07:00

control_test.go

ssh: add openssh controlmaster socket support

2026-05-21 19:39:36 -07:00

control.go

ssh: add openssh controlmaster socket support

2026-05-21 19:39:36 -07:00

doc.go

…

example_test.go

…

handshake_test.go

all: clean up minor issues found by staticcheck

2026-07-21 14:30:59 -07:00

handshake.go

ssh: permit empty but non-nil HostKeyAlgorithms, KeyExchanges, Ciphers, MACs

2026-07-22 10:37:01 -07:00

kex_test.go

ssh: improve DH GEX group selection using PreferredBits

2026-06-02 00:23:03 -07:00

kex.go

ssh: improve DH GEX group selection using PreferredBits

2026-06-02 00:23:03 -07:00

keys_test.go

all: clean up minor issues found by staticcheck

2026-07-21 14:30:59 -07:00

keys.go

ssh: raise the RSA modulus limit to 16384 bits

2026-07-13 20:33:21 -07:00

mac.go

…

mempipe_test.go

…

messages_test.go

ssh: sanitize various error messages

2026-07-13 12:23:17 -07:00

messages.go

ssh: sanitize various error messages

2026-07-13 12:23:17 -07:00

mlkem.go

…

mux_test.go

ssh: sanitize various error messages

2026-07-13 12:23:17 -07:00

mux.go

ssh: initialize new channels fully before adding them to chanList

2026-07-12 08:19:12 -07:00

server_multi_auth_test.go

ssh: fix data race in the doClientServerAuth test helper

2026-07-12 08:19:29 -07:00

server_test.go

ssh: report verified signature format to callback

2026-07-17 15:41:46 -07:00

server.go

ssh: report verified signature format to callback

2026-07-17 15:41:46 -07:00

session_test.go

all: clean up minor issues found by staticcheck

2026-07-21 14:30:59 -07:00

session.go

ssh: prevent malformed exit-status panic

2026-05-25 19:49:21 -07:00

ssh_gss_test.go

ssh: fix parsing of GSSAPI payloads offering multiple mechanisms

2026-07-23 08:19:57 -07:00

ssh_gss.go

ssh: fix parsing of GSSAPI payloads offering multiple mechanisms

2026-07-23 08:19:57 -07:00

streamlocal.go

ssh: drain stderr on forwarded TCP and Unix channels

2026-07-22 10:34:36 -07:00

tcpip_test.go

ssh: drain stderr on forwarded TCP and Unix channels

2026-07-22 10:34:36 -07:00

tcpip.go

ssh: drain stderr on forwarded TCP and Unix channels

2026-07-22 10:34:36 -07:00

testdata_test.go

…

transport_test.go

ssh: correctly ignore pre-banner lines

2026-08-17 08:34:06 -07:00

transport.go

ssh: correctly ignore pre-banner lines

2026-08-17 08:34:06 -07:00