Filippo ValsordaandKevin Wallace a5774263c1 ssh: send (and rename) keyboard-interactive name field to the client ...

The server side implementation was not actually populating the
SSH_MSG_USERAUTH_INFO_REQUEST field with the
KeyboardInteractiveChallenge argument, although the client side was
deserializing it and passing it to the KeyboardInteractiveChallenge
callback.

Anyway, the first field of SSH_MSG_USERAUTH_INFO_REQUEST is "name", not
"user". Maybe the confusion was due to the first field of
SSH_MSG_USERAUTH_REQUEST being the user.

RFC 4256, Section 3.3, says this about it

   One possibility is to use the name field (possibly
   prefixed with the application's name) as the title of a dialog window
   in which the prompt(s) are presented.

and examples include "CRYPTOCard Authentication", "Password
Authentication", and "Password Expired".

Co-authored-by: Kevin Wallace <kevin@pentabarf.net>
Change-Id: Ic6ec0dfea2122704603c44f42898a980689a15c9
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/372234
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>

2022-03-14 23:47:16 +00:00

..

agent

ssh: deprecate and replace SigAlgo constants

2022-03-14 23:46:46 +00:00

internal/bcrypt_pbkdf

ssh: support encrypted OpenSSH private keys

2020-02-04 10:40:54 +00:00

knownhosts

crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr

2019-01-23 08:56:48 +00:00

terminal

ssh/terminal: replace with a golang.org/x/term wrapper

2020-11-16 15:36:03 +00:00

test

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

testdata

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

benchmark_test.go

all: fix ineffectual assignments

2019-01-31 18:25:04 +00:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

ssh: remove unused buffer.eof return value

2017-09-25 11:19:01 +00:00

certs_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

certs.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

channel.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

cipher_test.go

ssh: don't assume packet plaintext size

2021-12-02 19:23:23 +00:00

cipher.go

ssh: don't assume packet plaintext size

2021-12-02 19:23:23 +00:00

client_auth_test.go

ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey

2022-02-09 19:56:52 +00:00

client_auth.go

ssh: send (and rename) keyboard-interactive name field to the client

2022-03-14 23:47:16 +00:00

client_test.go

ssh: deprecate and replace SigAlgo constants

2022-03-14 23:46:46 +00:00

client.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

common_test.go

ssh: invert algorithm choices on the server

2019-04-18 16:56:55 +00:00

common.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

connection.go

ssh: fixing a small typo in connection.go

2017-05-31 07:46:08 +00:00

doc.go

ssh: require host key checking in the ClientConfig

2017-03-30 15:57:35 +00:00

example_test.go

crypto/ssh: add Client.Close in Dial example

2020-10-12 17:37:05 +00:00

handshake_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

handshake.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

kex_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

kex.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

keys_test.go

ssh: deprecate and replace SigAlgo constants

2022-03-14 23:46:46 +00:00

keys.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

mac.go

ssh: Add the hmac-sha2-256-etm@openssh.com algorithm

2017-02-08 15:25:40 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

ssh: send (and rename) keyboard-interactive name field to the client

2022-03-14 23:47:16 +00:00

mux_test.go

ssh: don't err out on channel request msgs to unknown channels

2020-06-02 18:02:16 +00:00

mux.go

ssh: don't err out on channel request msgs to unknown channels

2020-06-02 18:02:16 +00:00

server.go

ssh: send (and rename) keyboard-interactive name field to the client

2022-03-14 23:47:16 +00:00

session_test.go

ssh: deprecate and replace SigAlgo constants

2022-03-14 23:46:46 +00:00

session.go

ssh: add IUTF8 constant from RFC 8160

2022-03-13 00:37:12 +00:00

ssh_gss_test.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

ssh_gss.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

streamlocal.go

ssh: also start forward listeners on ListenUnix

2018-05-14 16:50:30 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

ssh: don't start goroutines handling forwarded connections until needed

2018-05-14 11:17:49 +00:00

testdata_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

transport_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

transport.go

ssh: ignore MAC if AEAD ciphers negotiated

2022-03-12 13:11:42 +00:00