We add this support for the following reasons: - We are planning to expose recommended (secure) vs. supported (works, not necessarily recommended) algorithms. The DHGEX kex is currently only exposed as a client-side kex. To simplify the calling convention for this follow-on, we expose the server side too. - Some clients are quite inflexible with reference to kex algorithms choice, for example they offer: diffie-hellman-group-exchange-sha256, diffie-hellman-group-exchange-sha1, diffie-hellman-group14-sha1, diffie-hellman-group1-sha1 therefore DHGEX helps interoperability. We do not recommend the DHGEX kex as a whole: - the negotiation requires an extra round trip - the server must generate parameters (slow) or hardcode them, which defeats the security benefit over traditional DH. In this implementation we hardcode sending Oakley Group 14, Oakley Group 15 or Oakley Group 16 based on the requested max size. Users that are concerned with security of classical DH kex should migrate to kex based on EC or Ed25519. Fixes golang/go#54743 Change-Id: I127822e90efc36821af4aca679931f40a2023021 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/532415 Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Nicola Murino <nicola.murino@gmail.com> Reviewed-by: Filippo Valsorda <filippo@golang.org> Reviewed-by: Han-Wen Nienhuys <hanwen@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
156 lines
4.7 KiB
Go
156 lines
4.7 KiB
Go
// Copyright 2023 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package test
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"golang.org/x/crypto/internal/testenv"
|
|
"golang.org/x/crypto/ssh"
|
|
"golang.org/x/crypto/ssh/testdata"
|
|
)
|
|
|
|
func sshClient(t *testing.T) string {
|
|
if testing.Short() {
|
|
t.Skip("Skipping test that executes OpenSSH in -short mode")
|
|
}
|
|
sshCLI := os.Getenv("SSH_CLI_PATH")
|
|
if sshCLI == "" {
|
|
sshCLI = "ssh"
|
|
}
|
|
var err error
|
|
sshCLI, err = exec.LookPath(sshCLI)
|
|
if err != nil {
|
|
t.Skipf("Can't find an ssh(1) client to test against: %v", err)
|
|
}
|
|
return sshCLI
|
|
}
|
|
|
|
// setupSSHCLIKeys writes the provided key files to a temporary directory and
|
|
// returns the path to the private key.
|
|
func setupSSHCLIKeys(t *testing.T, keyFiles map[string][]byte, privKeyName string) string {
|
|
tmpDir := t.TempDir()
|
|
for fn, content := range keyFiles {
|
|
if err := os.WriteFile(filepath.Join(tmpDir, fn), content, 0600); err != nil {
|
|
t.Fatalf("WriteFile(%q): %v", fn, err)
|
|
}
|
|
}
|
|
return filepath.Join(tmpDir, privKeyName)
|
|
}
|
|
|
|
func TestSSHCLIAuth(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skipf("always fails on Windows, see #64403")
|
|
}
|
|
sshCLI := sshClient(t)
|
|
keyFiles := map[string][]byte{
|
|
"rsa": testdata.PEMBytes["rsa"],
|
|
"rsa.pub": ssh.MarshalAuthorizedKey(testPublicKeys["rsa"]),
|
|
"rsa-cert.pub": testdata.SSHCertificates["rsa-user-testcertificate"],
|
|
}
|
|
keyPrivPath := setupSSHCLIKeys(t, keyFiles, "rsa")
|
|
|
|
certChecker := ssh.CertChecker{
|
|
IsUserAuthority: func(k ssh.PublicKey) bool {
|
|
return bytes.Equal(k.Marshal(), testPublicKeys["ca"].Marshal())
|
|
},
|
|
UserKeyFallback: func(conn ssh.ConnMetadata, key ssh.PublicKey) (*ssh.Permissions, error) {
|
|
if conn.User() == "testpubkey" && bytes.Equal(key.Marshal(), testPublicKeys["rsa"].Marshal()) {
|
|
return nil, nil
|
|
}
|
|
|
|
return nil, fmt.Errorf("pubkey for %q not acceptable", conn.User())
|
|
},
|
|
}
|
|
|
|
config := &ssh.ServerConfig{
|
|
PublicKeyCallback: certChecker.Authenticate,
|
|
}
|
|
config.AddHostKey(testSigners["rsa"])
|
|
|
|
server, err := newTestServer(config)
|
|
if err != nil {
|
|
t.Fatalf("unable to start test server: %v", err)
|
|
}
|
|
defer server.Close()
|
|
|
|
port, err := server.port()
|
|
if err != nil {
|
|
t.Fatalf("unable to get server port: %v", err)
|
|
}
|
|
|
|
// test public key authentication.
|
|
cmd := testenv.Command(t, sshCLI, "-vvv", "-i", keyPrivPath, "-o", "StrictHostKeyChecking=no",
|
|
"-p", port, "testpubkey@127.0.0.1", "true")
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Fatalf("public key authentication failed, error: %v, command output %q", err, string(out))
|
|
}
|
|
// Test SSH user certificate authentication.
|
|
// The username must match one of the principals included in the certificate.
|
|
// The certificate "rsa-user-testcertificate" has "testcertificate" as principal.
|
|
cmd = testenv.Command(t, sshCLI, "-vvv", "-i", keyPrivPath, "-o", "StrictHostKeyChecking=no",
|
|
"-p", port, "testcertificate@127.0.0.1", "true")
|
|
out, err = cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Fatalf("user certificate authentication failed, error: %v, command output %q", err, string(out))
|
|
}
|
|
}
|
|
|
|
func TestSSHCLIKeyExchanges(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skipf("always fails on Windows, see #64403")
|
|
}
|
|
sshCLI := sshClient(t)
|
|
keyFiles := map[string][]byte{
|
|
"rsa": testdata.PEMBytes["rsa"],
|
|
"rsa.pub": ssh.MarshalAuthorizedKey(testPublicKeys["rsa"]),
|
|
}
|
|
keyPrivPath := setupSSHCLIKeys(t, keyFiles, "rsa")
|
|
|
|
keyExchanges := append(ssh.SupportedAlgorithms().KeyExchanges, ssh.InsecureAlgorithms().KeyExchanges...)
|
|
for _, kex := range keyExchanges {
|
|
t.Run(kex, func(t *testing.T) {
|
|
config := &ssh.ServerConfig{
|
|
Config: ssh.Config{
|
|
KeyExchanges: []string{kex},
|
|
},
|
|
PublicKeyCallback: func(conn ssh.ConnMetadata, key ssh.PublicKey) (*ssh.Permissions, error) {
|
|
if conn.User() == "testpubkey" && bytes.Equal(key.Marshal(), testPublicKeys["rsa"].Marshal()) {
|
|
return nil, nil
|
|
}
|
|
|
|
return nil, fmt.Errorf("pubkey for %q not acceptable", conn.User())
|
|
},
|
|
}
|
|
config.AddHostKey(testSigners["rsa"])
|
|
|
|
server, err := newTestServer(config)
|
|
if err != nil {
|
|
t.Fatalf("unable to start test server: %v", err)
|
|
}
|
|
defer server.Close()
|
|
|
|
port, err := server.port()
|
|
if err != nil {
|
|
t.Fatalf("unable to get server port: %v", err)
|
|
}
|
|
|
|
cmd := testenv.Command(t, sshCLI, "-vvv", "-i", keyPrivPath, "-o", "StrictHostKeyChecking=no",
|
|
"-o", fmt.Sprintf("KexAlgorithms=%s", kex), "-p", port, "testpubkey@127.0.0.1", "true")
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Fatalf("%s failed, error: %v, command output %q", kex, err, string(out))
|
|
}
|
|
})
|
|
}
|
|
}
|