Bryan C. Mills 23edec0b38 ssh: ensure that handshakeTransport goroutines have finished before Close returns ...

This fixes a data race in the tests for x/crypto/ssh, which expects to
be able to examine a transport's read and write counters without
locking after closing it.

(Given the number of goroutines, channels, and mutexes used in this
package, I wouldn't be surprised if other concurrency bugs remain.
I would suggest simplifying the concurrency in this package, but I
don't intend to follow up on that myself at the moment.)

Fixes golang/go#56957.

Change-Id: Ib1f1390b66707c66a3608e48f3f52483cff3c1f5
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/456758
Reviewed-by: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>

2022-12-12 22:32:12 +00:00

..

agent

all: use automatic RFC linking

2022-10-12 13:47:37 +00:00

internal/bcrypt_pbkdf

ssh: support encrypted OpenSSH private keys

2020-02-04 10:40:54 +00:00

knownhosts

crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr

2019-01-23 08:56:48 +00:00

terminal

ssh/terminal: replace with a golang.org/x/term wrapper

2020-11-16 15:36:03 +00:00

test

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

testdata

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

benchmark_test.go

all: fix ineffectual assignments

2019-01-31 18:25:04 +00:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

ssh: remove unused buffer.eof return value

2017-09-25 11:19:01 +00:00

certs_test.go

all: gofmt

2022-04-11 22:02:26 +00:00

certs.go

all: replace bytes.Compare with bytes.Equal

2022-10-05 02:52:14 +00:00

channel.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

cipher_test.go

ssh: don't assume packet plaintext size

2021-12-02 19:23:23 +00:00

cipher.go

all: use automatic RFC linking

2022-10-12 13:47:37 +00:00

client_auth_test.go

ssh: support rsa-sha2-256/512 on the server side

2022-11-12 16:25:23 +00:00

client_auth.go

ssh: support rsa-sha2-256/512 for client certificates

2022-03-15 16:07:06 +00:00

client_test.go

ssh: deprecate and replace SigAlgo constants

2022-03-14 23:46:46 +00:00

client.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

common_test.go

ssh: invert algorithm choices on the server

2019-04-18 16:56:55 +00:00

common.go

ssh: support rsa-sha2-256/512 on the server side

2022-11-12 16:25:23 +00:00

connection.go

all: use automatic RFC linking

2022-10-12 13:47:37 +00:00

doc.go

all: gofmt

2022-04-11 22:02:26 +00:00

example_test.go

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

handshake_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

handshake.go

ssh: ensure that handshakeTransport goroutines have finished before Close returns

2022-12-12 22:32:12 +00:00

kex_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

kex.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

keys_test.go

ssh: deprecate and replace SigAlgo constants

2022-03-14 23:46:46 +00:00

keys.go

all: fix a few function names on comments

2022-10-12 13:45:58 +00:00

mac.go

ssh: Add the hmac-sha2-256-etm@openssh.com algorithm

2017-02-08 15:25:40 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

ssh: fix typo

2022-11-04 14:06:20 +00:00

mux_test.go

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

mux.go

ssh: don't err out on channel request msgs to unknown channels

2020-06-02 18:02:16 +00:00

server.go

ssh: support rsa-sha2-256/512 on the server side

2022-11-12 16:25:23 +00:00

session_test.go

ssh: add ServerConfig.NoClientAuthCallback

2022-10-10 15:29:10 +00:00

session.go

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

ssh_gss_test.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

ssh_gss.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

streamlocal.go

ssh: also start forward listeners on ListenUnix

2018-05-14 16:50:30 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

ssh: don't start goroutines handling forwarded connections until needed

2018-05-14 11:17:49 +00:00

testdata_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

transport_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

transport.go

ssh: ignore MAC if AEAD ciphers negotiated

2022-03-12 13:11:42 +00:00