Han-Wen Nienhuys 77014cf7f9 ssh: prevent double kex at connection start, 2nd try ...

The previous attempt would fail in the following scenario:

* select picks "first" kex from requestKex

* read loop receives a remote kex, posts on requestKex (which is now
  empty) [*] for sending out a response, and sends pendingKex on startKex.

* select picks pendingKex from startKex, and proceeds to run the key
  exchange.

* the posting on requestKex in [*] now triggers a second key exchange.

Fixes #18861. 

Change-Id: I443e82f1d04c7f17d1485fdb87072b9feec26aa8
Reviewed-on: https://go-review.googlesource.com/36055
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>

2017-02-06 10:12:19 +00:00

..

agent

x/crypto/ssh/agent: honor constraints on keys in the keyring.

2016-09-22 17:06:29 +00:00

terminal

ssh/terminal: consume data before checking for an error.

2017-01-17 00:48:27 +00:00

test

x/crypto: fix typos

2016-07-06 16:40:51 +00:00

testdata

x/crypto/ssh: ParsePrivateKey errors out with encrypted private keys

2016-09-29 09:05:14 +00:00

benchmark_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

certs_test.go

ssh: fix flake in TestHostKeyCert

2015-08-02 23:53:45 +00:00

certs.go

x/crypto/ssh: add support for ed25519 keys

2016-05-12 13:28:31 +00:00

channel.go

ssh: soft code internal channel size for testing purposes

2017-01-23 10:44:52 +00:00

cipher_test.go

x/crypto: fix typos

2016-07-06 16:40:51 +00:00

cipher.go

x/crypto/ssh: add 3des-cbc as a non-default cipher

2016-05-15 12:48:58 +00:00

client_auth_test.go

ssh: Support multiple source-addresses, don't require IPv4 in tests.

2017-02-02 20:10:58 +00:00

client_auth.go

ssh: rewrite (re)keying logic.

2017-01-16 13:08:31 +00:00

client_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

client.go

ssh: soft code internal channel size for testing purposes

2017-01-23 10:44:52 +00:00

common.go

ssh: rationalize rekeying decisions.

2017-01-30 09:33:53 +00:00

connection.go

crypto/ssh: keep user in ConnMetadata if NoClientAuth is used

2016-08-24 15:16:49 +00:00

doc.go

crypto/ssh: fix the links to the SSH protocol documents

2015-04-16 17:18:06 +00:00

example_test.go

ssh: fix height/width order in RequestPty example

2016-10-04 13:31:33 +00:00

handshake_test.go

ssh: Support multiple source-addresses, don't require IPv4 in tests.

2017-02-02 20:10:58 +00:00

handshake.go

ssh: prevent double kex at connection start, 2nd try

2017-02-06 10:12:19 +00:00

kex_test.go

x/crypto/ssh: close memPipe after running kex test.

2015-08-17 22:17:06 +00:00

kex.go

ssh: bound DH public values to [2, p-2].

2016-10-10 21:14:46 +00:00

keys_test.go

x/crypto/ssh: Add FingerprintLegacyMD5 and FingerprintSHA256 methods

2016-11-22 14:27:12 +00:00

keys.go

crypto/ssh: fix parsing order for ssh.ParseDSAPrivateKey

2017-01-18 01:33:05 +00:00

mac.go

ssh: add hmac-sha2-256.

2015-05-14 18:39:32 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

mux_test.go

ssh: add debug print at the lowest level

2017-02-02 09:54:18 +00:00

mux.go

ssh: soft code internal channel size for testing purposes

2017-01-23 10:44:52 +00:00

server.go

ssh: Support multiple source-addresses, don't require IPv4 in tests.

2017-02-02 20:10:58 +00:00

session_test.go

x/crypto/ssh: handle missing exit status more gracefully.

2016-07-06 18:05:22 +00:00

session.go

x/crypto/ssh: handle missing exit status more gracefully.

2016-07-06 18:05:22 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

crypto/ssh: Handle error in dial to avoid a goroutine leak

2015-08-08 08:51:02 +00:00

testdata_test.go

x/crypto: fix typos

2016-07-06 16:40:51 +00:00

transport_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

transport.go

ssh: add debug print at the lowest level

2017-02-02 09:54:18 +00:00