Kaleb Elwert 6ab629be5e ssh: properly handle wrong guess for FirstKexFollows in server ...

In the initial key exchange, a client has the option of sending a
guessed key exchange packet. This guess is considered wrong (RFC 4253
Section 7) if "the kex algorithm and/or the host key algorithm is
guessed wrong (server and client have different preferred algorithm),
or if any of the other algorithms cannot be agreed upon...".

The library should be checking the first algorithm in the supported
algorithms, not the agreed algorithm. It also needs to check both the
kex algorithm and the host key algorithm.

Fixes golang/go#16962

Change-Id: I6b62b1f5b39731326280571d373635085135a2a1
Reviewed-on: https://go-review.googlesource.com/28750
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

2016-09-20 07:34:01 +00:00

..

agent

x/crypto/ssh/agent: ecdsa key/cert typo

2016-07-11 17:04:49 +00:00

terminal

x/crypto/ssh/terminal: have MakeRaw mirror cfmakeraw.

2016-07-18 21:10:49 +00:00

test

x/crypto: fix typos

2016-07-06 16:40:51 +00:00

testdata

x/crypto/ssh: add support for ed25519 keys

2016-05-12 13:28:31 +00:00

benchmark_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

certs_test.go

ssh: fix flake in TestHostKeyCert

2015-08-02 23:53:45 +00:00

certs.go

x/crypto/ssh: add support for ed25519 keys

2016-05-12 13:28:31 +00:00

channel.go

ssh: clarify error type if a SendRequest goes unanswered

2016-07-25 12:15:03 +00:00

cipher_test.go

x/crypto: fix typos

2016-07-06 16:40:51 +00:00

cipher.go

x/crypto/ssh: add 3des-cbc as a non-default cipher

2016-05-15 12:48:58 +00:00

client_auth_test.go

crypto/ssh: keep user in ConnMetadata if NoClientAuth is used

2016-08-24 15:16:49 +00:00

client_auth.go

x/crypto/ssh: Add support for retryable authentication

2016-07-04 10:34:16 +00:00

client_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

client.go

x/crypto/ssh: hide msgNewKeys in the transport layer.

2016-05-10 17:36:43 +00:00

common.go

x/crypto/ssh: add ed25519 certs to supportedHostKeyAlgos

2016-07-14 17:11:52 +00:00

connection.go

crypto/ssh: keep user in ConnMetadata if NoClientAuth is used

2016-08-24 15:16:49 +00:00

doc.go

crypto/ssh: fix the links to the SSH protocol documents

2015-04-16 17:18:06 +00:00

example_test.go

x/crypto/ssh: remove misleading comment, add example

2016-04-21 09:08:50 +00:00

handshake_test.go

x/crypto/ssh: hide msgNewKeys in the transport layer.

2016-05-10 17:36:43 +00:00

handshake.go

ssh: properly handle wrong guess for FirstKexFollows in server

2016-09-20 07:34:01 +00:00

kex_test.go

x/crypto/ssh: close memPipe after running kex test.

2015-08-17 22:17:06 +00:00

kex.go

x/crypto/ssh: make sure the initial key exchange happens once.

2016-04-12 17:14:56 +00:00

keys_test.go

x/crypto/ssh: add support for ed25519 keys

2016-05-12 13:28:31 +00:00

keys.go

x/crypto: fix typos

2016-07-06 16:40:51 +00:00

mac.go

ssh: add hmac-sha2-256.

2015-05-14 18:39:32 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

mux_test.go

x/crypto/ssh: interpret disconnect message as error in the transport layer.

2016-03-29 14:38:23 +00:00

mux.go

x/crypto/ssh: hide msgNewKeys in the transport layer.

2016-05-10 17:36:43 +00:00

server.go

crypto/ssh: keep user in ConnMetadata if NoClientAuth is used

2016-08-24 15:16:49 +00:00

session_test.go

x/crypto/ssh: handle missing exit status more gracefully.

2016-07-06 18:05:22 +00:00

session.go

x/crypto/ssh: handle missing exit status more gracefully.

2016-07-06 18:05:22 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

crypto/ssh: Handle error in dial to avoid a goroutine leak

2015-08-08 08:51:02 +00:00

testdata_test.go

x/crypto: fix typos

2016-07-06 16:40:51 +00:00

transport_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

transport.go

x/crypto/ssh: add 3des-cbc as a non-default cipher

2016-05-15 12:48:58 +00:00