Nicola Murino 64e0e99383 ssh: fix RSA certificate and public key authentication with older clients ...

After adding support for rsa-sha2-256/512 on the server side some edge
cases started to arise with old clients:

1) public key authentication with gpg-agent < 2.2.6 fails because we
   receive ssh-rsa as signature format and rsa-sha2-256 or rsa-sha2-512
   as algorithm.
   This is a bug in gpg-agent fixed in this commit:

   https://github.com/gpg/gnupg/commit/80b775bdbb852aa4a80292c9357e5b1876110c00

2) certificate authentication fails with OpenSSH 7.2-7.7 because we
   receive ssh-rsa-cert-v01@openssh.com as algorithm and rsa-sha2-256
   or rsa-sha2-512 as signature format.

This patch is based on CL 412854 and has been tested with every version
of OpenSSH from 7.1 to 7.9 and OpenSSH 9.3.

Fixes golang/go#53391

Change-Id: Id71f596f73d84efb5c76d6d5388432cccad3e3b1
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/506835
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>

2023-07-10 19:57:54 +00:00

..

agent

all: fix some comments

2023-03-20 20:33:29 +00:00

internal/bcrypt_pbkdf

ssh: support encrypted OpenSSH private keys

2020-02-04 10:40:54 +00:00

knownhosts

all: fix some comments

2023-01-30 18:50:24 +00:00

terminal

ssh/terminal: replace with a golang.org/x/term wrapper

2020-11-16 15:36:03 +00:00

test

ssh/test: set a timeout and WaitDelay on sshd subcommands

2023-06-15 16:06:57 +00:00

testdata

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

benchmark_test.go

all: fix ineffectual assignments

2019-01-31 18:25:04 +00:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

ssh: remove unused buffer.eof return value

2017-09-25 11:19:01 +00:00

certs_test.go

all: gofmt

2022-04-11 22:02:26 +00:00

certs.go

all: replace bytes.Compare with bytes.Equal

2022-10-05 02:52:14 +00:00

channel.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

cipher_test.go

ssh: add support for aes256-gcm@openssh.com

2023-02-15 20:22:00 +00:00

cipher.go

ssh: add support for aes256-gcm@openssh.com

2023-02-15 20:22:00 +00:00

client_auth_test.go

ssh: fix RSA certificate and public key authentication with older clients

2023-07-10 19:57:54 +00:00

client_auth.go

ssh: support rsa-sha2-256/512 for client certificates

2022-03-15 16:07:06 +00:00

client_test.go

ssh: deprecate and replace SigAlgo constants

2022-03-14 23:46:46 +00:00

client.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

common_test.go

ssh: invert algorithm choices on the server

2019-04-18 16:56:55 +00:00

common.go

ssh: fix RSA certificate and public key authentication with older clients

2023-07-10 19:57:54 +00:00

connection.go

all: fix some comments

2023-03-20 20:33:29 +00:00

doc.go

all: gofmt

2022-04-11 22:02:26 +00:00

example_test.go

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

handshake_test.go

ssh: skip unsupported tests on wasip1

2023-04-18 17:07:48 +00:00

handshake.go

ssh: ensure that handshakeTransport goroutines have finished before Close returns

2022-12-12 22:32:12 +00:00

kex_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

kex.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

keys_test.go

ssh: deprecate and replace SigAlgo constants

2022-03-14 23:46:46 +00:00

keys.go

ssh: document that ParseRawPrivateKey supports Ed25519 keys

2023-03-13 12:45:00 +00:00

mac.go

ssh: add hmac-sha2-512

2023-06-22 14:36:59 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

ssh: fix typo

2022-11-04 14:06:20 +00:00

mux_test.go

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

mux.go

ssh: don't err out on channel request msgs to unknown channels

2020-06-02 18:02:16 +00:00

server.go

ssh: fix RSA certificate and public key authentication with older clients

2023-07-10 19:57:54 +00:00

session_test.go

ssh: add ServerConfig.NoClientAuthCallback

2022-10-10 15:29:10 +00:00

session.go

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

ssh_gss_test.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

ssh_gss.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

streamlocal.go

ssh: also start forward listeners on ListenUnix

2018-05-14 16:50:30 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

ssh: don't start goroutines handling forwarded connections until needed

2018-05-14 11:17:49 +00:00

testdata_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

transport_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

transport.go

ssh: add support for aes256-gcm@openssh.com

2023-02-15 20:22:00 +00:00