Roland Shoemaker 6068a2e6cf ssh: ignore MAC if AEAD ciphers negotiated ...

If the server/client cipher chosen is one of the two AEAD ciphers that
we support (aes128-gcm@openssh.com and chacha20-poly1305@openssh.com),
don't attempt to find a common MAC algorithm in findAgreedAlgorithms.
Similarly in newPacketCipher, don't attempt to generate a MAC key if we
are using a AEAD cipher.

Fixes golang/go#51406

Change-Id: Id48ae72f052cb0a0c597b32e9901a0f218e4161f
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/389214
Trust: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>

2022-03-12 13:11:42 +00:00

..

agent

acme, sha3, ssh: fix the typos

2022-02-09 15:53:12 +00:00

internal/bcrypt_pbkdf

ssh: support encrypted OpenSSH private keys

2020-02-04 10:40:54 +00:00

knownhosts

crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr

2019-01-23 08:56:48 +00:00

terminal

ssh/terminal: replace with a golang.org/x/term wrapper

2020-11-16 15:36:03 +00:00

test

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

testdata

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

benchmark_test.go

all: fix ineffectual assignments

2019-01-31 18:25:04 +00:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

ssh: remove unused buffer.eof return value

2017-09-25 11:19:01 +00:00

certs_test.go

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

certs.go

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

channel.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

cipher_test.go

ssh: don't assume packet plaintext size

2021-12-02 19:23:23 +00:00

cipher.go

ssh: don't assume packet plaintext size

2021-12-02 19:23:23 +00:00

client_auth_test.go

ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey

2022-02-09 19:56:52 +00:00

client_auth.go

ssh: improve error message for KeyboardInteractiveChallenge

2020-10-16 22:06:09 +00:00

client_test.go

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

client.go

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

common_test.go

ssh: invert algorithm choices on the server

2019-04-18 16:56:55 +00:00

common.go

ssh: ignore MAC if AEAD ciphers negotiated

2022-03-12 13:11:42 +00:00

connection.go

ssh: fixing a small typo in connection.go

2017-05-31 07:46:08 +00:00

doc.go

ssh: require host key checking in the ClientConfig

2017-03-30 15:57:35 +00:00

example_test.go

crypto/ssh: add Client.Close in Dial example

2020-10-12 17:37:05 +00:00

handshake_test.go

ssh: ignore MAC if AEAD ciphers negotiated

2022-03-12 13:11:42 +00:00

handshake.go

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

kex_test.go

ssh: fix data race in dh group exchange sha256

2020-03-17 14:21:12 +00:00

kex.go

ssh: remove slow unnecessary diffie-hellman-group-exchange primality check

2020-09-30 16:06:38 +00:00

keys_test.go

ssh: reject unencrypted keys from ParsePrivateKeyWithPassphrase

2019-12-05 16:18:47 +00:00

keys.go

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

mac.go

ssh: Add the hmac-sha2-256-etm@openssh.com algorithm

2017-02-08 15:25:40 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

ssh: add diffie-hellman-group-exchange-sha256

2019-06-17 13:33:40 +00:00

mux_test.go

ssh: don't err out on channel request msgs to unknown channels

2020-06-02 18:02:16 +00:00

mux.go

ssh: don't err out on channel request msgs to unknown channels

2020-06-02 18:02:16 +00:00

server.go

ssh: fix typo

2022-03-07 21:11:46 +00:00

session_test.go

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

session.go

all: run gofmt -s on source code

2017-11-28 19:40:09 +00:00

ssh_gss_test.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

ssh_gss.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

streamlocal.go

ssh: also start forward listeners on ListenUnix

2018-05-14 16:50:30 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

ssh: don't start goroutines handling forwarded connections until needed

2018-05-14 11:17:49 +00:00

testdata_test.go

ssh: support RSA SHA-2 (RFC8332) signatures

2021-11-15 23:45:14 +00:00

transport_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

transport.go

ssh: ignore MAC if AEAD ciphers negotiated

2022-03-12 13:11:42 +00:00