Justin Gracenin 5f55bce93a ssh: fix protocol version exchange (for multi-line) ...

Fixes golang/go#23194

During SSH Protocol Version Exchange, a client may send metadata lines
prior to sending the SSH version string. To conform to the RFC, all SSH
implementations must support this (minimally, clients can ignore the
metadata lines).

For example, this is valid:
some-metadata
SSH-2.0-OpenSSH

The current Go implementation takes the first line it sees as
the version string (in this case, some-metadata). Then, it uses
the next line (SSH-2.0-OpenSSH) as part of key exchange, which
is guaranteed to fail.

Unfortunately, this SSH feature is used by some vendors and is part
of the official RFC: https://tools.ietf.org/html/rfc4253#section-4.2

Change-Id: I7be61700a07756353875bf43aad09a580ba533ff
Reviewed-on: https://go-review.googlesource.com/86675
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

2018-01-11 10:11:23 +00:00

..

agent

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

knownhosts

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

terminal

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

test

ssh: use t.Run for testing multiple ciphers/macs

2018-01-10 14:51:55 +00:00

testdata

ssh: accept ed25519 certs

2017-12-18 18:48:59 +00:00

benchmark_test.go

ssh: specify InsecureIgnoreHostKey in the benchmarks

2018-01-10 10:03:27 +00:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

ssh: remove unused buffer.eof return value

2017-09-25 11:19:01 +00:00

certs_test.go

ssh: accept ed25519 certs

2017-12-18 18:48:59 +00:00

certs.go

crypto/ssh: fix typo in error message in certs.go

2017-12-28 08:17:15 +00:00

channel.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

cipher_test.go

ssh: use t.Run for testing multiple ciphers/macs

2018-01-10 14:51:55 +00:00

cipher.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

client_auth_test.go

ssh: fix a formatting bug in a test

2017-07-10 17:40:29 +00:00

client_auth.go

ssh: add support for banners

2017-11-13 21:34:09 +00:00

client_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

client.go

ssh: add support for banners

2017-11-13 21:34:09 +00:00

common.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

connection.go

ssh: fixing a small typo in connection.go

2017-05-31 07:46:08 +00:00

doc.go

ssh: require host key checking in the ClientConfig

2017-03-30 15:57:35 +00:00

example_test.go

ssh: clarify intended use of Permissions.

2017-06-19 17:21:03 +00:00

handshake_test.go

crypto/ssh: fix tests on Go 1.7 on OpenBSD and Windows

2017-05-03 14:53:58 +00:00

handshake.go

ssh: add support for banners

2017-11-13 21:34:09 +00:00

kex_test.go

x/crypto/ssh: close memPipe after running kex test.

2015-08-17 22:17:06 +00:00

kex.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

keys_test.go

ssh: signal incorrect private key passwords with x509.IncorrectPasswordError

2017-06-28 15:01:44 +00:00

keys.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

mac.go

ssh: Add the hmac-sha2-256-etm@openssh.com algorithm

2017-02-08 15:25:40 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

mux_test.go

ssh: add debug print at the lowest level

2017-02-02 09:54:18 +00:00

mux.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

server.go

ssh: accept ed25519 certs

2017-12-18 18:48:59 +00:00

session_test.go

ssh: require host key checking in the ClientConfig

2017-03-30 15:57:35 +00:00

session.go

all: run gofmt -s on source code

2017-11-28 19:40:09 +00:00

streamlocal.go

ssh: support forwarding of Unix domain socket connections

2017-04-10 09:27:34 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

ssh: support forwarding of Unix domain socket connections

2017-04-10 09:27:34 +00:00

testdata_test.go

x/crypto: fix typos

2016-07-06 16:40:51 +00:00

transport_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

transport.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00