Nicola Murino ebb717d630 ssh: validate key type in SSH_MSG_USERAUTH_PK_OK response ...

According to RFC 4252 Section 7 the algorithm in SSH_MSG_USERAUTH_PK_OK
should match that of the request but some servers send the key type instead.
OpenSSH checks for the key type, so we do the same.

Fixes golang/go#66438
Fixes golang/go#64785
Fixes golang/go#56342
Fixes golang/go#54027

Change-Id: I2f733f0faece097e44ba7a97c868d30a53e21d79
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/573360
Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Nicola Murino <nicola.murino@gmail.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Joedian Reid <joedian@google.com>

2024-05-03 13:40:56 +00:00

..

agent

ssh/test: don't use DSA keys in integrations tests, update test RSA key

2024-02-14 13:16:51 +00:00

internal/bcrypt_pbkdf

ssh: support encrypted OpenSSH private keys

2020-02-04 10:40:54 +00:00

knownhosts

all: fix some comments

2023-01-30 18:50:24 +00:00

terminal

ssh/terminal: replace with a golang.org/x/term wrapper

2020-11-16 15:36:03 +00:00

test

ssh/test: work around for TestCiphers failures on macOS

2024-02-28 20:47:20 +00:00

testdata

ssh/test: don't use DSA keys in integrations tests, update test RSA key

2024-02-14 13:16:51 +00:00

benchmark_test.go

ssh: fix call to Fatalf from a non-test goroutine

2023-07-31 18:14:41 +00:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

ssh: remove unused buffer.eof return value

2017-09-25 11:19:01 +00:00

certs_test.go

all: remove redundant words in comments and fix some typos

2024-03-18 09:27:23 +00:00

certs.go

ssh: add MultiAlgorithmSigner

2023-09-20 18:10:30 +00:00

channel.go

ssh: defer channel window adjustment

2023-11-27 17:27:49 +00:00

cipher_test.go

ssh: add support for aes256-gcm@openssh.com

2023-02-15 20:22:00 +00:00

cipher.go

ssh: add support for aes256-gcm@openssh.com

2023-02-15 20:22:00 +00:00

client_auth_test.go

ssh: add test cases for compatibility with old (buggy) clients

2023-09-20 18:10:32 +00:00

client_auth.go

ssh: validate key type in SSH_MSG_USERAUTH_PK_OK response

2024-05-03 13:40:56 +00:00

client_test.go

ssh: wrap errors from client handshake

2023-11-27 17:24:46 +00:00

client.go

ssh: wrap errors from client handshake

2023-11-27 17:24:46 +00:00

common_test.go

ssh: fix call to Fatalf from a non-test goroutine

2023-07-31 18:14:41 +00:00

common.go

ssh: fix certificate authentication with OpenSSH 7.2-7.7

2023-11-23 17:23:14 +00:00

connection.go

all: fix some comments

2023-03-20 20:33:29 +00:00

doc.go

ssh: add server side support for ping@openssh.com protocol extension

2023-10-04 16:04:50 +00:00

example_test.go

all: remove redundant words in comments and fix some typos

2024-03-18 09:27:23 +00:00

handshake_test.go

ssh: implement strict KEX protocol changes

2023-12-18 16:33:08 +00:00

handshake.go

ssh: implement strict KEX protocol changes

2023-12-18 16:33:08 +00:00

kex_test.go

ssh: add diffie-hellman-group16-sha512 kex

2023-07-31 17:46:52 +00:00

kex.go

ssh: add diffie-hellman-group16-sha512 kex

2023-07-31 17:46:52 +00:00

keys_test.go

ssh/test: don't use DSA keys in integrations tests, update test RSA key

2024-02-14 13:16:51 +00:00

keys.go

ssh: try harder to detect incorrect passwords for legacy PEM encryption

2023-11-08 18:01:48 +00:00

mac.go

ssh: add hmac-sha2-512

2023-06-22 14:36:59 +00:00

mempipe_test.go

ssh: defer channel window adjustment

2023-11-27 17:27:49 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

ssh: add server side support for ping@openssh.com protocol extension

2023-10-04 16:04:50 +00:00

mux_test.go

ssh: defer channel window adjustment

2023-11-27 17:27:49 +00:00

mux.go

ssh: add server side support for ping@openssh.com protocol extension

2023-10-04 16:04:50 +00:00

server_multi_auth_test.go

ssh: add server side multi-step authentication

2024-04-03 07:40:24 +00:00

server_test.go

ssh: respect MaxAuthTries also for "none" auth attempts

2024-04-04 14:49:27 +00:00

server.go

ssh: respect MaxAuthTries also for "none" auth attempts

2024-04-04 14:49:27 +00:00

session_test.go

ssh: eliminate some goroutine leaks in tests and examples

2023-11-09 17:49:15 +00:00

session.go

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

ssh_gss_test.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

ssh_gss.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

streamlocal.go

ssh: also start forward listeners on ListenUnix

2018-05-14 16:50:30 +00:00

tcpip_test.go

ssh: add (*Client).DialContext method

2023-11-27 15:35:52 +00:00

tcpip.go

ssh: add (*Client).DialContext method

2023-11-27 15:35:52 +00:00

testdata_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

transport_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

transport.go

ssh: implement strict KEX protocol changes

2023-12-18 16:33:08 +00:00