Nicola Murino 42c83fffff ssh: try harder to detect incorrect passwords for legacy PEM encryption ...

Because of deficiencies in the format, DecryptPEMBlock does not always
detect an incorrect password. In these cases decrypted DER bytes is
random noise. If the parsing of the key returns an asn1.StructuralError
we return x509.IncorrectPasswordError.

Fixes golang/go#62265

Change-Id: Ib8b845f2bd01662c1f1421d35859a32ac5b78da7
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/538835
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>

2023-11-08 18:01:48 +00:00

..

agent

ssh: add support for SSH_AGENT_CONSTRAIN_EXTENSION with id 255

2023-10-11 10:27:03 +00:00

internal/bcrypt_pbkdf

ssh: support encrypted OpenSSH private keys

2020-02-04 10:40:54 +00:00

knownhosts

all: fix some comments

2023-01-30 18:50:24 +00:00

terminal

ssh/terminal: replace with a golang.org/x/term wrapper

2020-11-16 15:36:03 +00:00

test

ssh: add test case against ssh CLI

2023-10-24 07:12:59 +00:00

testdata

ssh: add test case against ssh CLI

2023-10-24 07:12:59 +00:00

benchmark_test.go

ssh: fix call to Fatalf from a non-test goroutine

2023-07-31 18:14:41 +00:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

ssh: remove unused buffer.eof return value

2017-09-25 11:19:01 +00:00

certs_test.go

ssh: add MultiAlgorithmSigner

2023-09-20 18:10:30 +00:00

certs.go

ssh: add MultiAlgorithmSigner

2023-09-20 18:10:30 +00:00

channel.go

all: fix errors reported by vet, golint

2017-11-28 17:48:09 +00:00

cipher_test.go

ssh: add support for aes256-gcm@openssh.com

2023-02-15 20:22:00 +00:00

cipher.go

ssh: add support for aes256-gcm@openssh.com

2023-02-15 20:22:00 +00:00

client_auth_test.go

ssh: add test cases for compatibility with old (buggy) clients

2023-09-20 18:10:32 +00:00

client_auth.go

ssh: add MultiAlgorithmSigner

2023-09-20 18:10:30 +00:00

client_test.go

ssh: ignore invalid MACs and KEXs just like we do for ciphers

2023-07-31 15:35:32 +00:00

client.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

common_test.go

ssh: fix call to Fatalf from a non-test goroutine

2023-07-31 18:14:41 +00:00

common.go

ssh: add diffie-hellman-group16-sha512 kex

2023-07-31 17:46:52 +00:00

connection.go

all: fix some comments

2023-03-20 20:33:29 +00:00

doc.go

ssh: add server side support for ping@openssh.com protocol extension

2023-10-04 16:04:50 +00:00

example_test.go

ssh: add MultiAlgorithmSigner

2023-09-20 18:10:30 +00:00

handshake_test.go

ssh: add MultiAlgorithmSigner

2023-09-20 18:10:30 +00:00

handshake.go

ssh: add server side support for ping@openssh.com protocol extension

2023-10-04 16:04:50 +00:00

kex_test.go

ssh: add diffie-hellman-group16-sha512 kex

2023-07-31 17:46:52 +00:00

kex.go

ssh: add diffie-hellman-group16-sha512 kex

2023-07-31 17:46:52 +00:00

keys_test.go

ssh: try harder to detect incorrect passwords for legacy PEM encryption

2023-11-08 18:01:48 +00:00

keys.go

ssh: try harder to detect incorrect passwords for legacy PEM encryption

2023-11-08 18:01:48 +00:00

mac.go

ssh: add hmac-sha2-512

2023-06-22 14:36:59 +00:00

mempipe_test.go

ssh: fix spelling of test so that it runs

2015-07-15 23:39:58 +00:00

messages_test.go

x/crypto/ssh: support more keytypes in the agent.

2016-04-25 17:01:51 +00:00

messages.go

ssh: add server side support for ping@openssh.com protocol extension

2023-10-04 16:04:50 +00:00

mux_test.go

ssh: fix call to Fatalf from a non-test goroutine

2023-07-31 18:14:41 +00:00

mux.go

ssh: add server side support for ping@openssh.com protocol extension

2023-10-04 16:04:50 +00:00

server.go

ssh: check the declared public key algo against decoded one

2023-09-05 16:18:45 +00:00

session_test.go

ssh: fix call to Fatalf from a non-test goroutine

2023-07-31 18:14:41 +00:00

session.go

all: replace io/ioutil with io and os package

2022-09-19 17:36:07 +00:00

ssh_gss_test.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

ssh_gss.go

ssh/gss: support kerberos authentication for ssh server and client

2019-05-10 10:41:15 +00:00

streamlocal.go

ssh: also start forward listeners on ListenUnix

2018-05-14 16:50:30 +00:00

tcpip_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

tcpip.go

ssh: don't start goroutines handling forwarded connections until needed

2018-05-14 11:17:49 +00:00

testdata_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

transport_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

transport.go

ssh: add support for aes256-gcm@openssh.com

2023-02-15 20:22:00 +00:00