Damien Miller
593c81af8a
Reading the peer's benner in readVersion() was incorrectly counting lines sent by the server before the actual `SSH-2.0` banner against the line limit for the banner itself. This is incorrect per RFC 4253 section 4.2, where the limit of 255 characters is written to apply only to the `SSH-` banner string itself. This instead limits pre-banner lines to 255 characters each but instead allows a maximum of 1024 lines. Change-Id: Ief014bb3413e26e8d2077d3eb204ceaea9dc9444 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/811320 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Nicola Murino <nicola.murino@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
126 lines
3.2 KiB
Go
126 lines
3.2 KiB
Go
// Copyright 2011 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package ssh
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/rand"
|
|
"encoding/binary"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestReadVersion(t *testing.T) {
|
|
longVersion := strings.Repeat("SSH-2.0-bla", 50)[:253]
|
|
multiLineVersion := strings.Repeat("ignored\r\n", 20) + "SSH-2.0-bla\r\n"
|
|
cases := map[string]string{
|
|
"SSH-2.0-bla\r\n": "SSH-2.0-bla",
|
|
"SSH-2.0-bla\n": "SSH-2.0-bla",
|
|
multiLineVersion: "SSH-2.0-bla",
|
|
longVersion + "\r\n": longVersion,
|
|
}
|
|
|
|
for in, want := range cases {
|
|
result, err := readVersion(bytes.NewBufferString(in))
|
|
if err != nil {
|
|
t.Errorf("readVersion(%q): %s", in, err)
|
|
}
|
|
got := string(result)
|
|
if got != want {
|
|
t.Errorf("got %q, want %q", got, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestReadVersionError(t *testing.T) {
|
|
tooLongVersion := strings.Repeat("SSH-2.0-bla", 60) + "\r\n"
|
|
multiLine := strings.Repeat("ignored\r\n", 50)
|
|
tooManyLines := strings.Repeat("ignored\r\n", 2000)
|
|
tooLongLine := strings.Repeat("blah ", 100) + "\r\n"
|
|
cases := []string{
|
|
tooLongVersion,
|
|
multiLine + tooLongVersion,
|
|
tooManyLines + "SSH-2.0-bla\r\n",
|
|
tooLongLine + "SSH-2.0-bla\r\n",
|
|
}
|
|
for _, in := range cases {
|
|
if _, err := readVersion(bytes.NewBufferString(in)); err == nil {
|
|
t.Errorf("readVersion(%q) should have failed", in)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestIgnorePreVersion(t *testing.T) {
|
|
longishLine := strings.Repeat("blah ", 30) + "\r\n"
|
|
multiLineVersion := strings.Repeat(longishLine, 100) + "SSH-2.0-bla\r\n"
|
|
if _, err := readVersion(bytes.NewBufferString(multiLineVersion)); err != nil {
|
|
t.Errorf("readVersion() got error %v, expected success", err)
|
|
}
|
|
}
|
|
|
|
func TestExchangeVersionsBasic(t *testing.T) {
|
|
v := "SSH-2.0-bla"
|
|
buf := bytes.NewBufferString(v + "\r\n")
|
|
them, err := exchangeVersions(buf, []byte("xyz"))
|
|
if err != nil {
|
|
t.Errorf("exchangeVersions: %v", err)
|
|
}
|
|
|
|
if want := "SSH-2.0-bla"; string(them) != want {
|
|
t.Errorf("got %q want %q for our version", them, want)
|
|
}
|
|
}
|
|
|
|
func TestExchangeVersions(t *testing.T) {
|
|
cases := []string{
|
|
"not\x000allowed",
|
|
"not allowed\x01\r\n",
|
|
}
|
|
for _, c := range cases {
|
|
buf := bytes.NewBufferString("SSH-2.0-bla\r\n")
|
|
if _, err := exchangeVersions(buf, []byte(c)); err == nil {
|
|
t.Errorf("exchangeVersions(%q): should have failed", c)
|
|
}
|
|
}
|
|
}
|
|
|
|
type closerBuffer struct {
|
|
bytes.Buffer
|
|
}
|
|
|
|
func (b *closerBuffer) Close() error {
|
|
return nil
|
|
}
|
|
|
|
func TestTransportMaxPacketWrite(t *testing.T) {
|
|
buf := &closerBuffer{}
|
|
tr := newTransport(buf, rand.Reader, true)
|
|
huge := make([]byte, maxPacket+1)
|
|
err := tr.writePacket(huge)
|
|
if err == nil {
|
|
t.Errorf("transport accepted write for a huge packet.")
|
|
}
|
|
}
|
|
|
|
func TestTransportMaxPacketReader(t *testing.T) {
|
|
var header [5]byte
|
|
huge := make([]byte, maxPacket+128)
|
|
binary.BigEndian.PutUint32(header[0:], uint32(len(huge)))
|
|
// padding.
|
|
header[4] = 0
|
|
|
|
buf := &closerBuffer{}
|
|
buf.Write(header[:])
|
|
buf.Write(huge)
|
|
|
|
tr := newTransport(buf, rand.Reader, true)
|
|
_, err := tr.readPacket()
|
|
if err == nil {
|
|
t.Errorf("transport succeeded reading huge packet.")
|
|
} else if !strings.Contains(err.Error(), "large") {
|
|
t.Errorf("got %q, should mention %q", err.Error(), "large")
|
|
}
|
|
}
|