eiac/crypto
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
332 Commits 11 Branches 57 Tags
d68c3ecb62c850b645dc072a8d78006286bf81ca
Commit Graph
20 Commits
Author SHA1 Message Date
Thomas Desrosiers 6c2080b3cc crypto/ssh: clearer error messages when "no ciphers in common" 
The error message reported by the ssh client when it can't find a
"cipher" in common between the client and server was overly vague.  This
adds more detailed error messages to findAgreedAlgorithms so that the
user can more easily identify which of the components can't reach
agreement.

Change-Id: I4d985e92fea964793213e5600b52b3141e712000
Reviewed-on: https://go-review.googlesource.com/13817
Reviewed-by: Adam Langley <agl@golang.org>
 2015-08-29 19:16:37 +00:00
Adam Langley 2dfe547928 go.crypto/ssh: use permissions from public key cache when accepting a key. 
Fixes golang/go#7913.

LGTM=hanwen
R=hanwen
CC=golang-codereviews
https://golang.org/cl/96220043
 2014-05-12 11:19:56 -07:00
Han-Wen Nienhuys 6f0540ef5e go.crypto/ssh: try authentication methods in ClientConfig order. 
LGTM=jpsugar, agl
R=agl, jpsugar
CC=golang-codereviews
https://golang.org/cl/92240045
 2014-05-12 11:16:49 -07:00
Adam Langley fa50e7408b go.crypto/ssh: import gosshnew. 
See https://groups.google.com/d/msg/Golang-nuts/AoVxQ4bB5XQ/i8kpMxdbVlEJ

R=hanwen
CC=golang-codereviews
https://golang.org/cl/86190043
 2014-04-09 13:57:52 -07:00
Han-Wen Nienhuys 105632d35b go.crypto/ssh: only close connection if it was open in TestClientUnsupportedKex. 
R=dave
CC=golang-dev
https://golang.org/cl/15450046
 2013-10-24 04:12:59 +11:00
Han-Wen Nienhuys 934c14ffe9 go.crypto/ssh: introduce Signer method, an abstraction of 
private keys.

R=agl, jpsugar, jonathan.mark.pittman
CC=golang-dev
https://golang.org/cl/13338044
 2013-09-19 14:45:31 -04:00
Han-Wen Nienhuys e62b2aead4 go.crypto/ssh: introduce PublicKey interface type. 
Public functions affected:
-AgentKey.Key
-AgentClient.SignRequest
-ClientKeyring.Key
-MarshalPublicKey
-ParsePublicKey

R=agl, jpsugar, jmpittman
CC=golang-dev
https://golang.org/cl/13642043
 2013-09-13 14:25:14 -04:00
Jonathan Pittman 6a743c56c7 go.crypto/ssh: Begin adding server side support for more than RSA for client key auth 
R=agl, dave, hanwen
CC=ekg, golang-dev
https://golang.org/cl/13528044
 2013-09-09 13:06:04 -04:00
Han-Wen Nienhuys f17d130281 go.crypto/ssh: remove misleading marshalPrivRSA. 
Properly capitalize publicKey throughout.

R=golang-dev
CC=agl, dave, golang-dev, jpsugar
https://golang.org/cl/13415046
 2013-09-05 11:36:51 -04:00
Han-Wen Nienhuys d7d50b0a7c go.crypto/ssh: implement ECDH. 
Implement elliptic-curve Diffie-Hellman, including host key signature
verification.

Moves host key cryptographic verification to ClientConn.handshake(), so
RSA host keys are also verified.

Fixes golang/go#6158.

R=dave, agl
CC=golang-dev
https://golang.org/cl/13021045
 2013-08-28 10:50:25 -04:00
Han-Wen Nienhuys c7df565dd4 go.crypto/ssh: implement keyboard-interactive auth (RFC 4256), both 
on client and server-side.

R=dave, agl
CC=gobot, golang-dev
https://golang.org/cl/9853050
 2013-06-06 10:44:12 -04:00
Adam Langley 4002be2701 go.crypto/ssh: run gofmt 
gofmt got better at removing trailing whitespace.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6929044
 2012-12-10 18:12:36 -05:00
Dave Cheney 1582bf0781 go.crypto/ssh: never negotiate unsupported ciphers 
Fixes golang/go#4285.

Adding a new cipher that is supported by the remote end, but not supported by our client causes that cipher to be considered a valid candidate. This fails later in setupKeys when there is no cipherModes configuration.

In summary, unsupported ciphers cannot be willed into existence by adding them to the client config. This change enforces this.

R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/6780047
 2012-10-30 18:13:59 +11:00
Dave Cheney 096d0eae01 go.crypto/ssh: fix misplaced defer 
Fixes golang/go#3972.

R=golang-dev, agl, r
CC=golang-dev
https://golang.org/cl/6448166
 2012-08-18 15:41:45 +10:00
Adam Langley 63f855d724 ssh: cosmetic cleanups 
These are the cosmetic cleanups from the bits of code that I
rereviewed.

1) stringLength now takes a int; the length of the string. Too many
   callers were allocating with stringLength([]byte(s)) and
   stringLength only needs to call len().

2) agent.go now has sendAndReceive to remove logic that was
   duplicated.

3) We now reject negative DH values

4) We now reject empty packets rather than crashing.

R=dave, jonathan.mark.pittman
CC=golang-dev
https://golang.org/cl/6061052
 2012-04-20 15:17:42 -04:00
Fazlul Shahriar df1b4d2fcd go.crypto/ssh: fix example in documentation 
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/5905048
 2012-03-27 14:40:42 -04:00
Dave Cheney 6de97b525f go.crypto/ssh: improve support for MAC algorithms 
Also, add support for hmac-sha1.

At the suggestion of AGL hmac-md5, and hmac-md5-96
support was not included.

Fixes golang/go#3095.

R=golang-dev, agl, huin
CC=golang-dev
https://golang.org/cl/5696065
 2012-02-27 19:40:52 -05:00
Adam Langley d33bbf2cb3 ssh: use *rsa.PublicKey or *dsa.PublicKey in interfaces. 
Everywhere else in the code base, when we have an interface{} which is
a stand in for a public key, we use *foo.PublicKey rather than
foo.PublicKey. This change makes ssh reflect that.

R=dave, r
CC=golang-dev
https://golang.org/cl/5686067
 2012-02-23 10:42:21 -05:00
Daniel Theophanes 2b43ac23a9 go.crypto/ssh: add User to ServerConn and pass *ServerConn to callbacks. 
R=golang-dev, dave, agl
CC=golang-dev
https://golang.org/cl/5577070
 2012-01-30 15:30:11 -05:00
Russ Cox 470549d502 go.crypto: initial code 
Manual edits to README.
Moved from main Go repository, deleted Makefiles, ran gofix -r go1rename.

Tested with: go test code.google.com/p/go.crypto/...

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5564059
 2012-01-25 15:31:12 -05:00