eiac/crypto
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.crypto/ssh: ensure {Server,Client}Conn do not expose io.ReadWriter

Browse Source 
Transport should not be a ReadWriter. It can only write packets, i.e. no partial reads or writes. Furthermore, you can currently do ClientConn.Write() while the connection is live, which sends raw bytes over the connection. Doing so will confuse the transports because the data is not encrypted.

As a consequence, ClientConn and ServerConn stop being a net.Conn

Finally, ensure that {Server,Client}Conn implement LocalAddr and RemoteAddr methods that previously were exposed by an embedded net.Conn field.

R=hanwen
CC=golang-dev
https://golang.org/cl/16610043
This commit is contained in:
Dave Cheney
2013-10-25 06:29:58 +11:00
parent 105632d35b
commit c0d640c887
6 changed files with 88 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ssh/client_auth.go
+2 -2
View File
@@ -14,10 +14,10 @@ import (
// authenticate authenticates with the remote server. See RFC 4252.
func (c *ClientConn) authenticate(session []byte) error {
// initiate user auth session
if err := c.writePacket(marshal(msgServiceRequest, serviceRequestMsg{serviceUserAuth})); err != nil {
if err := c.transport.writePacket(marshal(msgServiceRequest, serviceRequestMsg{serviceUserAuth})); err != nil {
return err
}
packet, err := c.readPacket()
packet, err := c.transport.readPacket()
if err != nil {
return err
}