crypto/ssh: keep user in ConnMetadata if NoClientAuth is used

The current behaviour of the crypto/ssh server implementation is to
remove the username from ConnMetadata if the connection is done without
authentication (NoClientAuth). This appears to be a bug.

This behaviour is different from other SSH server implementations like
for example Paramiko (Python) which keeps the username.

Additionally RFC4252 (https://www.ietf.org/rfc/rfc4252.txt) section
5 states the username has to be included in every USERAUTH message.

Change-Id: I27fa50db92eb535e90fe088453faa6f2a76ee31f
Reviewed-on: https://go-review.googlesource.com/27612
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

This commit is contained in:

Sven Blumenstein

2016-08-24 15:16:49 +00:00

committed by

Han-Wen Nienhuys

parent b35ccbc95a

commit 986d331358

3 changed files with 29 additions and 2 deletions

									
										ssh/server.go
									
		-1
	
												View File
												
				@@ -284,7 +284,6 @@ userAuthLoop:

						switch userAuthReq.Method {

						case "none":

							if config.NoClientAuth {

								s.user = ""

								authErr = nil

							}

						case "password":