sha3: fix Sum results for SHAKE functions on s390x
Sum was taking the digest from the state which is correct for SHA-3 functions but not for SHAKE functions. Updates golang/go#66804 Change-Id: If782464d773262075950e3168128c0d46e4a6530 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/578715 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Than McIntosh <thanm@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Michael Munday <mike.munday@lowrisc.org>
This commit is contained in:
@@ -188,6 +188,34 @@ func TestKeccak(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestShakeSum tests that the output of Sum matches the output of Read.
|
||||
func TestShakeSum(t *testing.T) {
|
||||
tests := [...]struct {
|
||||
name string
|
||||
hash ShakeHash
|
||||
expectedLen int
|
||||
}{
|
||||
{"SHAKE128", NewShake128(), 32},
|
||||
{"SHAKE256", NewShake256(), 64},
|
||||
{"cSHAKE128", NewCShake128([]byte{'X'}, nil), 32},
|
||||
{"cSHAKE256", NewCShake256([]byte{'X'}, nil), 64},
|
||||
}
|
||||
|
||||
for _, test := range tests {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
s := test.hash.Sum(nil)
|
||||
if len(s) != test.expectedLen {
|
||||
t.Errorf("Unexpected digest length: got %d, want %d", len(s), test.expectedLen)
|
||||
}
|
||||
r := make([]byte, test.expectedLen)
|
||||
test.hash.Read(r)
|
||||
if !bytes.Equal(s, r) {
|
||||
t.Errorf("Mismatch between Sum and Read:\nSum: %s\nRead: %s", hex.EncodeToString(s), hex.EncodeToString(r))
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// TestUnalignedWrite tests that writing data in an arbitrary pattern with
|
||||
// small input buffers.
|
||||
func TestUnalignedWrite(t *testing.T) {
|
||||
|
||||
Reference in New Issue
Block a user