mirror of
https://github.com/github/awesome-copilot.git
synced 2026-10-12 14:54:16 +00:00
* Add submission-gate check, merge-risk tiers, and PR status state machine (#4184) Phase 2 (enforcement) of github/awesome-copilot#4184: - submission-gate aggregate required check (reader) with infra vs contribution failure classification - merge-risk:low/medium/high classification from .github/risk-tiers.yml with tier approval policy - Submission Gate Writer maintaining state labels and a persistent status comment - /rerun-checks and /request-review PR commands - validate-skills and validate-submission-gate workflows, unit tests, and maintainer docs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix codespell findings and add spelling to submission gate checks Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Harden submission gate per review feedback - Publish the submission-gate check from the trusted writer via the Checks API and flag any other submission-gate check run as tampering - Fail closed on truncated file lists, unscannable diffs, permission lookup errors, and skipped required checks - Discard evaluations when the PR head or reviews change mid-run - Low tier requires a resource owner approval - Commands must start the comment, matching the workflow filter Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Address #4190 review: command reader/writer, pools, paths, staleness - Split /rerun-checks and /request-review into a read-only issue_comment reader and a workflow_run writer that re-reads the comment, PR, and permission before writing. - Drop the workflow-security pool; agentic workflows and hooks are content (medium unless they add scripts or hook commands); the core pool is core-maintainers. - Include each check's workflow file and eng scripts in its paths. - Discard evaluations when the base branch or risk labels change; run the gate on PR edits (retargeting). - Correct copies of the writer's check that claim success while the evaluation fails. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fail closed on lost contributor signal; publish gate check before labels - A contributor check whose pr-check job succeeded but whose result artifact is missing or unreadable is now an infrastructure failure, so a lost HIGH signal can't lower the approval tier. - Publish the submission-gate check right after stale-state revalidation; label and comment sync are independent and reported afterwards. - Revert the self-path added to validate-agentic-workflows-pr.yml's trigger: that workflow rejects any .github change. Exempt it in the drift test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fail closed on bad routing config; advisory checks never hold the gate - loadGateConfig: a missing review-routing.yml still falls back, but a file that can't be parsed (or whose pools isn't a mapping) now throws instead of silently relaxing approvals. - Pending required: false checks no longer keep the PR in awaiting-automation or the gate check in progress, and the polling loop doesn't wait on them. They render as pending (advisory). - PR commands: 👀 marks a command as claimed; 🚀 is written only after the reply is posted and is the only replay guard, so a run that failed partway can be retried. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix codespell: unparseable -> unparsable Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
113 lines
4.5 KiB
YAML
113 lines
4.5 KiB
YAML
name: Submission Gate
|
|
|
|
# Read-only preview for every PR. Waits for the applicable checks listed in
|
|
# .github/submission-gate.yml, classifies the PR into a merge-risk tier
|
|
# (.github/risk-tiers.yml), and previews the approvals that tier requires.
|
|
# This workflow never publishes the required `submission-gate` check: a PR can edit
|
|
# pull_request workflows, so the trusted submission-gate-writer.yml recomputes the
|
|
# result with default-branch code and publishes that check, the labels, and the
|
|
# status comment. See docs/maintainers/submission-gate.md.
|
|
|
|
on:
|
|
pull_request:
|
|
# `edited` covers retargeting to another base branch, which changes the applicable checks.
|
|
types: [opened, synchronize, reopened, ready_for_review, edited]
|
|
pull_request_review:
|
|
types: [submitted, edited, dismissed]
|
|
|
|
permissions:
|
|
actions: read
|
|
checks: read
|
|
contents: read
|
|
pull-requests: read
|
|
|
|
concurrency:
|
|
group: submission-gate-${{ github.event.pull_request.number }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
# Must not be named submission-gate: the writer treats any other check with that name as tampering.
|
|
evaluate:
|
|
name: evaluate
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 50
|
|
steps:
|
|
# Gate logic and policy come from the base commit so a PR cannot change how it is judged.
|
|
- name: Checkout trusted base
|
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
|
with:
|
|
ref: ${{ github.event.pull_request.base.sha }}
|
|
persist-credentials: false
|
|
sparse-checkout: |
|
|
.github
|
|
eng
|
|
package.json
|
|
package-lock.json
|
|
|
|
- name: Check for gate logic on base
|
|
id: base
|
|
run: |
|
|
if [ -f eng/submission-gate.mjs ] && [ -f .github/submission-gate.yml ] && [ -f .github/risk-tiers.yml ]; then
|
|
echo "has-gate=true" >> "$GITHUB_OUTPUT"
|
|
else
|
|
echo "has-gate=false" >> "$GITHUB_OUTPUT"
|
|
fi
|
|
|
|
# Bootstrap only: the PR that introduces the gate has no base copy of it. This job
|
|
# has a read-only token, and such PRs are merge-risk:high by path.
|
|
- name: Checkout PR (bootstrap)
|
|
if: steps.base.outputs.has-gate != 'true'
|
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
|
with:
|
|
persist-credentials: false
|
|
clean: true
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
|
|
with:
|
|
node-version: "22"
|
|
cache: "npm"
|
|
|
|
- name: Install dependencies
|
|
run: npm ci --ignore-scripts
|
|
|
|
- name: Evaluate submission
|
|
uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
|
|
env:
|
|
GH_TOKEN: ${{ github.token }}
|
|
BOOTSTRAP: ${{ steps.base.outputs.has-gate != 'true' }}
|
|
with:
|
|
script: |
|
|
const path = require('path');
|
|
const { pathToFileURL } = require('url');
|
|
|
|
if (process.env.BOOTSTRAP === 'true') {
|
|
core.warning('The base branch has no submission gate yet; evaluating with the gate from this PR.');
|
|
}
|
|
const root = process.env.GITHUB_WORKSPACE;
|
|
const gate = await import(pathToFileURL(path.join(root, 'eng', 'submission-gate.mjs')).href);
|
|
const config = gate.loadGateConfig(root);
|
|
const pullNumber = context.payload.pull_request.number;
|
|
|
|
const evaluation = await gate.evaluateSubmission(github, {
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
pullNumber,
|
|
config,
|
|
expectedHeadSha: context.payload.pull_request.head.sha,
|
|
wait: true,
|
|
token: process.env.GH_TOKEN,
|
|
log: (message) => core.info(message),
|
|
});
|
|
|
|
if (evaluation.stale) {
|
|
core.info('The PR head changed during evaluation; the run for the new head will report instead.');
|
|
return;
|
|
}
|
|
const runUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;
|
|
await core.summary.addRaw(gate.renderStatusComment(evaluation, { gateRunUrl: runUrl })).write();
|
|
|
|
// Preview only; the writer publishes the authoritative submission-gate check.
|
|
core.info(`PR #${pullNumber}: state=${evaluation.state}, risk=${evaluation.risk.tier}`);
|
|
for (const line of gate.gateFailureSummary(evaluation)) core.notice(line);
|