mirror of
https://github.com/github/awesome-copilot.git
synced 2026-10-12 14:54:16 +00:00
* Add submission-gate check, merge-risk tiers, and PR status state machine (#4184) Phase 2 (enforcement) of github/awesome-copilot#4184: - submission-gate aggregate required check (reader) with infra vs contribution failure classification - merge-risk:low/medium/high classification from .github/risk-tiers.yml with tier approval policy - Submission Gate Writer maintaining state labels and a persistent status comment - /rerun-checks and /request-review PR commands - validate-skills and validate-submission-gate workflows, unit tests, and maintainer docs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix codespell findings and add spelling to submission gate checks Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Harden submission gate per review feedback - Publish the submission-gate check from the trusted writer via the Checks API and flag any other submission-gate check run as tampering - Fail closed on truncated file lists, unscannable diffs, permission lookup errors, and skipped required checks - Discard evaluations when the PR head or reviews change mid-run - Low tier requires a resource owner approval - Commands must start the comment, matching the workflow filter Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Address #4190 review: command reader/writer, pools, paths, staleness - Split /rerun-checks and /request-review into a read-only issue_comment reader and a workflow_run writer that re-reads the comment, PR, and permission before writing. - Drop the workflow-security pool; agentic workflows and hooks are content (medium unless they add scripts or hook commands); the core pool is core-maintainers. - Include each check's workflow file and eng scripts in its paths. - Discard evaluations when the base branch or risk labels change; run the gate on PR edits (retargeting). - Correct copies of the writer's check that claim success while the evaluation fails. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fail closed on lost contributor signal; publish gate check before labels - A contributor check whose pr-check job succeeded but whose result artifact is missing or unreadable is now an infrastructure failure, so a lost HIGH signal can't lower the approval tier. - Publish the submission-gate check right after stale-state revalidation; label and comment sync are independent and reported afterwards. - Revert the self-path added to validate-agentic-workflows-pr.yml's trigger: that workflow rejects any .github change. Exempt it in the drift test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fail closed on bad routing config; advisory checks never hold the gate - loadGateConfig: a missing review-routing.yml still falls back, but a file that can't be parsed (or whose pools isn't a mapping) now throws instead of silently relaxing approvals. - Pending required: false checks no longer keep the PR in awaiting-automation or the gate check in progress, and the polling loop doesn't wait on them. They render as pending (advisory). - PR commands: 👀 marks a command as claimed; 🚀 is written only after the reply is posted and is the only replay guard, so a run that failed partway can be retried. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix codespell: unparseable -> unparsable Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
99 lines
3.6 KiB
YAML
99 lines
3.6 KiB
YAML
name: PR Commands Writer
|
|
|
|
# Trusted writer for /rerun-checks and /request-review. Runs default-branch code after the
|
|
# read-only PR Commands workflow completes. The artifact only names a comment and a PR;
|
|
# the comment body, the PR state, and the commenter's permission are re-read from the API
|
|
# before anything is written. See docs/maintainers/submission-gate.md.
|
|
|
|
on:
|
|
workflow_run:
|
|
workflows: ["PR Commands"]
|
|
types: [completed]
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: pr-commands-writer-${{ github.event.workflow_run.id }}
|
|
cancel-in-progress: false
|
|
|
|
jobs:
|
|
run-command:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 10
|
|
permissions:
|
|
actions: write
|
|
contents: read
|
|
issues: write
|
|
pull-requests: write
|
|
if: >-
|
|
github.event.workflow_run.event == 'issue_comment' &&
|
|
github.event.workflow_run.conclusion == 'success'
|
|
steps:
|
|
- name: Download command request
|
|
id: download-request
|
|
continue-on-error: true
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
|
|
with:
|
|
name: pr-command-request
|
|
path: ${{ runner.temp }}/pr-command-request
|
|
run-id: ${{ github.event.workflow_run.id }}
|
|
github-token: ${{ github.token }}
|
|
|
|
- name: Checkout default branch
|
|
if: steps.download-request.outcome == 'success'
|
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
|
with:
|
|
persist-credentials: false
|
|
sparse-checkout: |
|
|
.github
|
|
eng
|
|
package.json
|
|
package-lock.json
|
|
|
|
- name: Setup Node.js
|
|
if: steps.download-request.outcome == 'success'
|
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
|
|
with:
|
|
node-version: "22"
|
|
cache: "npm"
|
|
|
|
- name: Install dependencies
|
|
if: steps.download-request.outcome == 'success'
|
|
run: npm ci --ignore-scripts
|
|
|
|
- name: Run command
|
|
if: steps.download-request.outcome == 'success'
|
|
uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
|
|
with:
|
|
script: |
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { pathToFileURL } = require('url');
|
|
|
|
const root = process.env.GITHUB_WORKSPACE;
|
|
const gate = await import(pathToFileURL(path.join(root, 'eng', 'submission-gate.mjs')).href);
|
|
const config = gate.loadGateConfig(root);
|
|
const { owner, repo } = context.repo;
|
|
const workflowRun = context.payload.workflow_run;
|
|
|
|
const requestPath = path.join(process.env.RUNNER_TEMP, 'pr-command-request', 'request.json');
|
|
const raw = fs.readFileSync(requestPath, 'utf8');
|
|
if (raw.length > 4096) throw new Error('PR command request is too large');
|
|
const { prNumber, commentId } = gate.validatePrCommandRequest(JSON.parse(raw), { workflowRunId: workflowRun.id });
|
|
|
|
const result = await gate.runPrCommand(github, {
|
|
owner,
|
|
repo,
|
|
prNumber,
|
|
commentId,
|
|
config,
|
|
defaultBranch: context.payload.repository?.default_branch || 'main',
|
|
log: (message) => core.info(message),
|
|
});
|
|
core.info(result.status === 'handled' ? `Handled /${result.command} on #${prNumber}.` : `Ignored comment ${commentId}: ${result.reason}.`);
|
|
|
|
- name: Note missing artifact
|
|
if: steps.download-request.outcome != 'success'
|
|
run: echo "No pr-command-request artifact was available; nothing to do."
|