mirror of
https://github.com/github/awesome-copilot.git
synced 2026-10-12 23:04:14 +00:00
James MontemagnoandCopilot App
d6131471b8
* Add submission-gate check, merge-risk tiers, and PR status state machine (#4184) Phase 2 (enforcement) of github/awesome-copilot#4184: - submission-gate aggregate required check (reader) with infra vs contribution failure classification - merge-risk:low/medium/high classification from .github/risk-tiers.yml with tier approval policy - Submission Gate Writer maintaining state labels and a persistent status comment - /rerun-checks and /request-review PR commands - validate-skills and validate-submission-gate workflows, unit tests, and maintainer docs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix codespell findings and add spelling to submission gate checks Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Harden submission gate per review feedback - Publish the submission-gate check from the trusted writer via the Checks API and flag any other submission-gate check run as tampering - Fail closed on truncated file lists, unscannable diffs, permission lookup errors, and skipped required checks - Discard evaluations when the PR head or reviews change mid-run - Low tier requires a resource owner approval - Commands must start the comment, matching the workflow filter Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Address #4190 review: command reader/writer, pools, paths, staleness - Split /rerun-checks and /request-review into a read-only issue_comment reader and a workflow_run writer that re-reads the comment, PR, and permission before writing. - Drop the workflow-security pool; agentic workflows and hooks are content (medium unless they add scripts or hook commands); the core pool is core-maintainers. - Include each check's workflow file and eng scripts in its paths. - Discard evaluations when the base branch or risk labels change; run the gate on PR edits (retargeting). - Correct copies of the writer's check that claim success while the evaluation fails. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fail closed on lost contributor signal; publish gate check before labels - A contributor check whose pr-check job succeeded but whose result artifact is missing or unreadable is now an infrastructure failure, so a lost HIGH signal can't lower the approval tier. - Publish the submission-gate check right after stale-state revalidation; label and comment sync are independent and reported afterwards. - Revert the self-path added to validate-agentic-workflows-pr.yml's trigger: that workflow rejects any .github change. Exempt it in the drift test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fail closed on bad routing config; advisory checks never hold the gate - loadGateConfig: a missing review-routing.yml still falls back, but a file that can't be parsed (or whose pools isn't a mapping) now throws instead of silently relaxing approvals. - Pending required: false checks no longer keep the PR in awaiting-automation or the gate check in progress, and the polling loop doesn't wait on them. They render as pending (advisory). - PR commands: 👀 marks a command as claimed; 🚀 is written only after the reply is posted and is the only replay guard, so a run that failed partway can be retried. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix codespell: unparseable -> unparsable Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
81 lines
2.4 KiB
YAML
81 lines
2.4 KiB
YAML
name: PR Risk Scan — Gate
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
types: [opened, synchronize, reopened]
|
|
paths:
|
|
- "skills/**"
|
|
- "agents/**"
|
|
- "workflows/**"
|
|
- "plugins/**"
|
|
- "hooks/**"
|
|
- "instructions/**"
|
|
- "eng/pr-risk-scan.mjs"
|
|
- ".github/workflows/pr-risk-scan.yml"
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
scan:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Collect changed files
|
|
run: |
|
|
git diff --name-only --diff-filter=ACMR "origin/${{ github.base_ref }}...HEAD" \
|
|
| awk '!/^(README\.md|docs\/README\.[^/]+\.md)$/' \
|
|
> changed-files.txt
|
|
echo "Changed files:"
|
|
cat changed-files.txt || true
|
|
|
|
- name: Run PR risk scanner
|
|
run: |
|
|
mkdir -p pr-risk-results
|
|
set +e
|
|
node ./eng/pr-risk-scan.mjs \
|
|
--files changed-files.txt \
|
|
--output-json pr-risk-results/results.json \
|
|
--output-md pr-risk-results/report.md
|
|
scan_exit_code=$?
|
|
set -e
|
|
|
|
if [ $scan_exit_code -ne 0 ]; then
|
|
cat > pr-risk-results/results.json <<EOF
|
|
{
|
|
"generated_at": "$(date -u +"%Y-%m-%dT%H:%M:%SZ")",
|
|
"scanner_status": "error",
|
|
"finding_count": 0,
|
|
"severity_counts": { "high": 0, "medium": 0, "info": 0 },
|
|
"findings": [],
|
|
"error": "Scanner failed. See workflow logs."
|
|
}
|
|
EOF
|
|
cat > pr-risk-results/report.md <<'EOF'
|
|
<!-- pr-risk-scan-results -->
|
|
## 🔒 PR Risk Scan Results
|
|
|
|
Scanner execution failed for this run, so findings could not be generated.
|
|
|
|
> This is a soft-gate report. Please inspect the workflow logs for diagnostics.
|
|
EOF
|
|
fi
|
|
echo "$scan_exit_code" > pr-risk-results/scan-exit-code.txt
|
|
|
|
- name: Save metadata
|
|
run: |
|
|
echo "${{ github.event.pull_request.number }}" > pr-risk-results/pr-number.txt
|
|
|
|
- name: Upload scan artifact
|
|
if: always()
|
|
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7
|
|
with:
|
|
name: pr-risk-scan-results
|
|
path: pr-risk-results/
|
|
retention-days: 1
|