Awesome/awesome-copilot
1
0
Fork 0
mirror of https://github.com/github/awesome-copilot.git synced 2026-10-15 08:11:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(external-plugins): block approval during intake reruns

Browse Source 
Remove stale ready-for-review state before evaluating edited submissions or running quality gates. Require a current ready state before fast-tracking or approving, and cover the pending transition with focused tests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 821f4796-505e-4fb8-96cf-0b5bbf80a636
This commit is contained in:
Aaron Powell
2026-10-13 11:58:49 +11:00
co-authored by Copilot App
parent f4088ee185
commit a48dab5961
7 changed files with 119 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/extensions/external-plugin-review-board/extension.mjs
+5 -2
View File
@@ -134,8 +134,11 @@ async function postDecision({ number, kind, comment }) {
const status = await gh.getIssueStatus(store.state.repo, number);
if (status.state !== "OPEN") throw new Error(`#${number} is ${status.state.toLowerCase()}. Refresh the board.`);
if (kind === "approve" && !status.labels.includes("ready-for-review")) {
throw new Error(`#${number} is no longer labelled ready-for-review, so /approve would be ignored.`);
if (
kind === "approve" &&
(!status.labels.includes("ready-for-review") || status.labels.includes("awaiting-review"))
) {
throw new Error(`#${number} is pending intake or is no longer ready-for-review, so /approve would be ignored.`);
}
const text = stripCommand(comment, kind);
.github/extensions/external-plugin-review-board/lib/state.mjs
+12 -4
View File
@@ -17,12 +17,14 @@ export const COLUMNS = [
const HISTORY_LIMIT = 200;
export const FIRST_PARTY_LABEL = "first party";
// Submissions from first-party organizations skip AI triage and land in Accept. Only cards without
// an AI review, queued review, or manual bucket are fast-tracked so maintainer choices are kept;
// dragging a card back to Unreviewed opts it out so it gets a normal AI review.
// Validated submissions from first-party organizations skip AI triage and land in Accept. Only
// cards without an AI review, queued review, or manual bucket are fast-tracked so maintainer
// choices are kept; dragging a card back to Unreviewed opts it out so it gets a normal AI review.
function applyFirstPartyFastTrack(item) {
if (
!item.labels?.includes(FIRST_PARTY_LABEL) ||
!item.labels?.includes("ready-for-review") ||
item.labels?.includes("awaiting-review") ||
item.fastTrackDismissed ||
item.decision ||
item.review ||
@@ -44,7 +46,13 @@ function applyFirstPartyFastTrack(item) {
}
function clearFirstPartyFastTrack(item) {
if (item.labels?.includes(FIRST_PARTY_LABEL) || !item.review?.fastTracked || item.reviewStatus === "queued") {
if (
(item.labels?.includes(FIRST_PARTY_LABEL) &&
item.labels?.includes("ready-for-review") &&
!item.labels?.includes("awaiting-review")) ||
!item.review?.fastTracked ||
item.reviewStatus === "queued"
) {
return;
}
item.review = null;