Awesome/awesome-copilot
1
0
Fork 0
mirror of https://github.com/github/awesome-copilot.git synced 2026-08-13 20:59:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enforce external plugin ref/sha consistency (#2463)

Browse Source 
* Enforce external plugin ref/sha consistency

Extract shared ref/sha normalization and consistency checks into eng/lib and reuse them in intake plus quality gate flows.

Add a dedicated ref/sha consistency quality gate surfaced in PR/intake summaries, and add targeted tests for matching and mismatched refs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6afe21ad-eafa-4c90-a1f2-053dedac7625

* Address review: tree/blob ref errors and PR workflow ref/sha column

- resolveCommitShaAtReadRef: classify rev-parse failure as 'fail'
  instead of 'infra_error' because a successfully-fetched ref that
  doesn't dereference to a commit is a submitter problem, not infra.
- validateRemoteRepository (intake): treat HTTP 422 from the commit
  endpoint as a submitter error; all other non-404 errors remain
  transient warnings requiring maintainer re-run.
- external-plugin-pr-quality-gates.yml: add ref/sha consistency
  column to the per-plugin quality table and failure details block.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6afe21ad-eafa-4c90-a1f2-053dedac7625

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6afe21ad-eafa-4c90-a1f2-053dedac7625
This commit is contained in:
Aaron Powell
2026-07-29 15:28:13 +10:00
committed by GitHub
parent 1e14bd4faa
commit 8ae5a99109
7 changed files with 397 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
eng/external-plugin-pr-quality-gates.mjs
+3 -1
View File
@@ -74,12 +74,14 @@ function createValidationFailureQuality(errors) {
vally_lint_status: "fail",
smoke_status: "not_run",
version_match_status: "not_run",
ref_sha_consistency_status: "not_run",
canvas_structure_status: "not_run",
failure_class: "submitter_fixes",
summary: "Plugin entry failed external.json validation. Fix the listed errors and re-run quality checks.",
vally_lint_output: output,
smoke_output: "Install smoke test skipped due to external.json validation errors.",
version_match_output: "Version match skipped due to external.json validation errors.",
ref_sha_consistency_output: "Ref/SHA consistency check skipped due to external.json validation errors.",
canvas_structure_output: "Canvas structure check skipped due to external.json validation errors.",
};
}
@@ -107,7 +109,7 @@ export async function runExternalPluginPrQualityGates(plugins) {
? "No changed external plugin entries were detected in plugins/external.json."
: checkedPlugins
.map((entry) =>
`- ${entry.name}: vally-lint=${entry.quality.vally_lint_status}, install-smoke=${entry.quality.smoke_status}, version-match=${entry.quality.version_match_status}, canvas-structure=${entry.quality.canvas_structure_status}, overall=${entry.quality.overall_status}`
`- ${entry.name}: vally-lint=${entry.quality.vally_lint_status}, install-smoke=${entry.quality.smoke_status}, version-match=${entry.quality.version_match_status}, ref-sha-consistency=${entry.quality.ref_sha_consistency_status}, canvas-structure=${entry.quality.canvas_structure_status}, overall=${entry.quality.overall_status}`
)
.join("\n");