Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Aaron Powell
2026-02-10 14:31:07 +11:00
committed by GitHub
parent 4ddc77bb36
commit 6210128ab1
4 changed files with 26 additions and 5 deletions

View File

@@ -159,6 +159,10 @@ function getDisplayName(filePath, kind) {
} else if (kind === "instruction") {
return basename.replace(".instructions.md", "");
} else if (kind === "hook") {
// For folder-based hooks like hooks/<hook>/README.md, use the folder name.
if (basename.toLowerCase() === "readme.md") {
return path.basename(path.dirname(filePath));
}
return basename.replace(".hook.md", "");
} else if (kind === "skill") {
return path.basename(filePath);

View File

@@ -164,7 +164,24 @@ const SKILL_DESCRIPTION_MAX_LENGTH = 1024;
const DOCS_DIR = path.join(ROOT_FOLDER, "docs");
export {
AGENTS_DIR, AKA_INSTALL_URLS, COLLECTIONS_DIR,
COOKBOOK_DIR, DOCS_DIR, HOOKS_DIR, INSTRUCTIONS_DIR, MAX_COLLECTION_ITEMS, PROMPTS_DIR, repoBaseUrl, ROOT_FOLDER, SKILL_DESCRIPTION_MAX_LENGTH, SKILL_DESCRIPTION_MIN_LENGTH, SKILL_NAME_MAX_LENGTH, SKILL_NAME_MIN_LENGTH, SKILLS_DIR, TEMPLATES, vscodeInsidersInstallImage, vscodeInstallImage
AGENTS_DIR,
AKA_INSTALL_URLS,
COLLECTIONS_DIR,
COOKBOOK_DIR,
DOCS_DIR,
HOOKS_DIR,
INSTRUCTIONS_DIR,
MAX_COLLECTION_ITEMS,
PROMPTS_DIR,
repoBaseUrl,
ROOT_FOLDER,
SKILL_DESCRIPTION_MAX_LENGTH,
SKILL_DESCRIPTION_MIN_LENGTH,
SKILL_NAME_MAX_LENGTH,
SKILL_NAME_MIN_LENGTH,
SKILLS_DIR,
TEMPLATES,
vscodeInsidersInstallImage,
vscodeInstallImage
};

View File

@@ -263,7 +263,7 @@ function validateCollectionItems(items) {
// Validate hook-specific frontmatter
if (item.kind === "hook") {
const hookValidation = validateHookFile(filePath, i + 1);
const hookValidation = validateHookFile(filePath);
if (hookValidation) {
return hookValidation;
}