mirror of
https://github.com/github/awesome-copilot.git
synced 2026-07-14 01:51:02 +00:00
Switch skill CI validation workflows to vally lint (#2030)
* Switch skill CI checks to vally lint Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Adding Vally to allowed words * case sensitivity * Migrate external plugin quality gates from skill-validator to vally lint Replace the downloaded skill-validator binary with px @microsoft/vally-cli lint in the external plugin quality gates pipeline: - Remove downloadSkillValidator() and SKILL_VALIDATOR_ARCHIVE_URL constant - Replace uildSkillValidatorArgs() + unSkillValidatorGate() with uildVallyLintArgs() + unVallyLintGate() that run px vally-cli lint per resolved skill directory (falling back to the full plugin root when no specific skill paths can be resolved from plugin.json) - Rename result keys skill_validator_status / skill_validator_output to ally_lint_status / ally_lint_output throughout both ng/external-plugin-quality-gates.mjs and ng/external-plugin-intake.mjs - Update PR comment markdown to show 'vally lint' instead of 'skill-validator' - Update CONTRIBUTING.md prose references accordingly Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use @microsoft/vally library directly instead of vally-cli subprocess Replace the npx-spawned vally-cli process with a direct call to the @microsoft/vally core library in the external plugin quality gates scripts: - Add @microsoft/vally as a devDependency in package.json - Import runLint and LintConsoleReporter from @microsoft/vally - Replace runVallyLintGate() process spawn with async API call: - runLint({ rootPath }) returns structured LintResults - LintConsoleReporter with a Writable capture stream collects text output without printing to stdout - Make runExternalPluginQualityGates() async (propagated to runExternalPluginPrQualityGates() and both main entry points) - Use Promise.all in runExternalPluginPrQualityGates() for parallel plugin checks - Fix remaining skill_validator_status reference in pr-quality-gates summary string (now vally-lint=...) and YAML workflow table header - Add 'npm install @microsoft/vally' step to both calling workflows This removes a layer of indirection (Node -> npx -> CLI -> library) and replaces it with a direct in-process library call, which is faster, more reliable, and gives structured access to lint results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Aaron Powell
GitHub
@@ -1,4 +1,4 @@
|
||||
name: Skill Validator — PR Gate
|
||||
name: Vally Lint — PR Gate
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
@@ -22,37 +22,10 @@ jobs:
|
||||
with:
|
||||
fetch-depth: 0
|
||||
|
||||
# ── Download & cache skill-validator ──────────────────────────
|
||||
- name: Get cache key date
|
||||
id: cache-date
|
||||
run: echo "date=$(date +%Y-%m-%d)" >> "$GITHUB_OUTPUT"
|
||||
|
||||
- name: Restore skill-validator from cache
|
||||
id: cache-sv
|
||||
uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
|
||||
- name: Setup Node.js
|
||||
uses: actions/setup-node@3235b876344febd2b5f2414c5edc3a01b7f10a06 # v4.2.0
|
||||
with:
|
||||
path: .skill-validator
|
||||
key: skill-validator-linux-x64-${{ steps.cache-date.outputs.date }}
|
||||
restore-keys: |
|
||||
skill-validator-linux-x64-
|
||||
|
||||
- name: Download skill-validator
|
||||
if: steps.cache-sv.outputs.cache-hit != 'true'
|
||||
run: |
|
||||
mkdir -p .skill-validator
|
||||
curl -fsSL \
|
||||
"https://github.com/dotnet/skills/releases/download/skill-validator-nightly/skill-validator-linux-x64.tar.gz" \
|
||||
-o .skill-validator/skill-validator-linux-x64.tar.gz
|
||||
tar -xzf .skill-validator/skill-validator-linux-x64.tar.gz -C .skill-validator
|
||||
rm .skill-validator/skill-validator-linux-x64.tar.gz
|
||||
chmod +x .skill-validator/skill-validator
|
||||
|
||||
- name: Save skill-validator to cache
|
||||
if: steps.cache-sv.outputs.cache-hit != 'true'
|
||||
uses: actions/cache/save@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
|
||||
with:
|
||||
path: .skill-validator
|
||||
key: skill-validator-linux-x64-${{ steps.cache-date.outputs.date }}
|
||||
node-version: 20
|
||||
|
||||
# ── Detect changed skills & agents ────────────────────────────
|
||||
- name: Detect changed skills and agents
|
||||
@@ -111,8 +84,8 @@ jobs:
|
||||
|
||||
echo "Found $SKILL_COUNT skill dir(s) and $AGENT_COUNT agent file(s) to check."
|
||||
|
||||
# ── Run skill-validator check ─────────────────────────────────
|
||||
- name: Run skill-validator check
|
||||
# ── Run vally lint check ───────────────────────────────────────
|
||||
- name: Run vally lint check
|
||||
id: check
|
||||
if: steps.detect.outputs.total != '0'
|
||||
env:
|
||||
@@ -134,53 +107,58 @@ jobs:
|
||||
done <<< "$AGENT_FILES_RAW"
|
||||
fi
|
||||
|
||||
CMD=(.skill-validator/skill-validator check --verbose)
|
||||
EXIT_CODE=0
|
||||
: > vally-output.txt
|
||||
|
||||
if [ ${#SKILL_DIRS[@]} -gt 0 ]; then
|
||||
CMD+=(--skills "${SKILL_DIRS[@]}")
|
||||
if [ ${#SKILL_DIRS[@]} -eq 0 ] && [ ${#AGENT_FILES[@]} -eq 0 ]; then
|
||||
echo "No skills or agents to validate." | tee -a vally-output.txt
|
||||
fi
|
||||
|
||||
for skill_dir in "${SKILL_DIRS[@]}"; do
|
||||
echo "### Linting ${skill_dir}" | tee -a vally-output.txt
|
||||
set +e
|
||||
OUTPUT=$(npx --yes @microsoft/vally-cli lint "$skill_dir" --verbose 2>&1)
|
||||
CMD_EXIT=$?
|
||||
set -e
|
||||
echo "$OUTPUT" | tee -a vally-output.txt
|
||||
echo "" >> vally-output.txt
|
||||
|
||||
if [ "$CMD_EXIT" -ne 0 ]; then
|
||||
EXIT_CODE=1
|
||||
fi
|
||||
done
|
||||
|
||||
if [ ${#AGENT_FILES[@]} -gt 0 ]; then
|
||||
CMD+=(--agents "${AGENT_FILES[@]}")
|
||||
{
|
||||
echo "### Agent files detected (not linted by vally)"
|
||||
echo "ℹ️ Vally currently lints SKILL.md content. Agent files were detected but skipped:"
|
||||
printf '%s\n' "${AGENT_FILES[@]}"
|
||||
echo ""
|
||||
} | tee -a vally-output.txt
|
||||
fi
|
||||
|
||||
printf 'Running: '
|
||||
printf '%q ' "${CMD[@]}"
|
||||
echo
|
||||
|
||||
# Capture output; don't fail the workflow (warn-only mode)
|
||||
set +e
|
||||
OUTPUT=$("${CMD[@]}" 2>&1)
|
||||
EXIT_CODE=$?
|
||||
set -e
|
||||
|
||||
echo "exit_code=$EXIT_CODE" >> "$GITHUB_OUTPUT"
|
||||
|
||||
# Save output to file (multi-line safe)
|
||||
echo "$OUTPUT" > sv-output.txt
|
||||
|
||||
echo "$OUTPUT"
|
||||
|
||||
# ── Upload results for the commenting workflow ────────────────
|
||||
- name: Save metadata
|
||||
if: always()
|
||||
run: |
|
||||
mkdir -p sv-results
|
||||
echo "${{ github.event.pull_request.number }}" > sv-results/pr-number.txt
|
||||
echo "${{ steps.detect.outputs.total }}" > sv-results/total.txt
|
||||
echo "${{ steps.detect.outputs.skill_count }}" > sv-results/skill-count.txt
|
||||
echo "${{ steps.detect.outputs.agent_count }}" > sv-results/agent-count.txt
|
||||
echo "${{ steps.check.outputs.exit_code }}" > sv-results/exit-code.txt
|
||||
if [ -f sv-output.txt ]; then
|
||||
cp sv-output.txt sv-results/sv-output.txt
|
||||
mkdir -p vally-results
|
||||
echo "${{ github.event.pull_request.number }}" > vally-results/pr-number.txt
|
||||
echo "${{ steps.detect.outputs.total }}" > vally-results/total.txt
|
||||
echo "${{ steps.detect.outputs.skill_count }}" > vally-results/skill-count.txt
|
||||
echo "${{ steps.detect.outputs.agent_count }}" > vally-results/agent-count.txt
|
||||
echo "${{ steps.check.outputs.exit_code }}" > vally-results/exit-code.txt
|
||||
if [ -f vally-output.txt ]; then
|
||||
cp vally-output.txt vally-results/vally-output.txt
|
||||
fi
|
||||
|
||||
- name: Upload results
|
||||
if: always()
|
||||
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7
|
||||
with:
|
||||
name: skill-validator-results
|
||||
path: sv-results/
|
||||
name: vally-lint-results
|
||||
path: vally-results/
|
||||
retention-days: 1
|
||||
|
||||
- name: Post skip notice if no skills changed
|
||||
|
||||
Reference in New Issue
Block a user