From fbb8c6273b38f879f1186e2be3121aab1402cd92 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Thu, 4 Jun 2020 10:12:36 -0400 Subject: [PATCH] Switched to parentElement optionals --- src/browser/renderer/dom/DomRenderer.ts | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/browser/renderer/dom/DomRenderer.ts b/src/browser/renderer/dom/DomRenderer.ts index 5e6231f36..9082e36bc 100644 --- a/src/browser/renderer/dom/DomRenderer.ts +++ b/src/browser/renderer/dom/DomRenderer.ts @@ -98,16 +98,10 @@ export class DomRenderer extends Disposable implements IRenderer { // Outside influences such as React unmounts may manipulate the DOM before our disposal. // https://github.com/xtermjs/xterm.js/issues/2960 - for (const element of [ - this._rowContainer, - this._selectionContainer, - this._themeStyleElement, - this._dimensionsStyleElement - ]) { - if (element.parentElement === this._screenElement) { - this._screenElement.removeChild(element); - } - } + this._rowContainer.parentElement?.removeChild(this._rowContainer); + this._selectionContainer.parentElement?.removeChild(this._selectionContainer); + this._themeStyleElement.parentElement?.removeChild(this._themeStyleElement); + this._dimensionsStyleElement.parentElement?.removeChild(this._dimensionsStyleElement); super.dispose(); }