From c62e6dd765a9afd2214a1267006345aadee5a719 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 26 May 2026 21:39:27 -0700 Subject: [PATCH] Register BufferNamespaceApi onBufferActivate listener with disposables (#5906) Wrap the onBufferActivate subscription in this._register so it is disposed when BufferNamespaceApi is disposed, matching the pattern used elsewhere in the codebase. Co-authored-by: Cursor Agent Co-authored-by: Daniel Imms --- src/common/public/BufferNamespaceApi.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/public/BufferNamespaceApi.ts b/src/common/public/BufferNamespaceApi.ts index 425b1798c..b9744f943 100644 --- a/src/common/public/BufferNamespaceApi.ts +++ b/src/common/public/BufferNamespaceApi.ts @@ -20,7 +20,7 @@ export class BufferNamespaceApi extends Disposable implements IBufferNamespaceAp super(); this._normal = new BufferApiView(this._core.buffers.normal, 'normal'); this._alternate = new BufferApiView(this._core.buffers.alt, 'alternate'); - this._core.buffers.onBufferActivate(() => this._onBufferChange.fire(this.active)); + this._register(this._core.buffers.onBufferActivate(() => this._onBufferChange.fire(this.active))); } public get active(): IBufferApi { if (this._core.buffers.active === this._core.buffers.normal) { return this.normal; }