From 9f232d981b81368fdcea34c44aa6baec651da0cb Mon Sep 17 00:00:00 2001 From: Anthony Kim Date: Tue, 16 Jun 2026 19:53:03 -0700 Subject: [PATCH] destructure doc from target like the old days --- src/browser/services/MouseService.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/browser/services/MouseService.ts b/src/browser/services/MouseService.ts index 4b3e14dc4..353e0581d 100644 --- a/src/browser/services/MouseService.ts +++ b/src/browser/services/MouseService.ts @@ -47,7 +47,7 @@ export class MouseService implements IMouseService { } public bindMouse(target: IMouseServiceTarget, register: (disposable: IDisposable) => void, focus: () => void): void { - const { element } = target; + const { element, document } = target; /** * Event listener state handling. @@ -76,7 +76,7 @@ export class MouseService implements IMouseService { }; this._altMouseCursor = new AltMouseCursorController( element, - target.document, + document, () => this._mouseStateService.areMouseEventsActive && !!this._optionsService.rawOptions.mouseEventsRequireAlt ); @@ -239,7 +239,8 @@ export class MouseService implements IMouseService { // Note: Other emulators also do this for 'mousedown' while a button // is held, we currently limit 'mousedown' to the terminal only. // Use the element's current document in case it moved to another window after open. - const listenerDocument = ctx.target.element.ownerDocument ?? ctx.target.document; + const { element, document: targetDocument } = ctx.target; + const listenerDocument = element.ownerDocument ?? targetDocument; if (ctx.requestedEvents.mouseup) { ctx.mouseupListener.value = addDisposableListener(listenerDocument, 'mouseup', ctx.requestedEvents.mouseup); }