From 8dfed8f979093b5c6a73e055324033214e07a387 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Fri, 11 Feb 2022 17:08:08 -0600 Subject: [PATCH] be safe and check if container contains element before removing --- src/browser/services/DecorationService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/services/DecorationService.ts b/src/browser/services/DecorationService.ts index 2ea164293..287852247 100644 --- a/src/browser/services/DecorationService.ts +++ b/src/browser/services/DecorationService.ts @@ -106,7 +106,7 @@ export class Decoration extends Disposable implements IDecoration { } private _createElement(renderService: IRenderService, shouldRecreate?: boolean): void { - if (shouldRecreate && this._element) { + if (shouldRecreate && this._element && this._container.contains(this._element)) { this._container.removeChild(this._element); } this._element = document.createElement('div');