From 163868ff601c0fe5d160ed6518f76d6653aafa14 Mon Sep 17 00:00:00 2001 From: Anthony Kim Date: Sat, 7 Mar 2026 23:32:02 -0800 Subject: [PATCH 1/2] Remove redundant bitmask in RGB->RGBA conversion --- addons/addon-image/src/kitty/KittyGraphicsHandler.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/addon-image/src/kitty/KittyGraphicsHandler.ts b/addons/addon-image/src/kitty/KittyGraphicsHandler.ts index 2e43accb4..7964fe9c1 100644 --- a/addons/addon-image/src/kitty/KittyGraphicsHandler.ts +++ b/addons/addon-image/src/kitty/KittyGraphicsHandler.ts @@ -752,9 +752,9 @@ export class KittyGraphicsHandler implements IApcHandler, IResetHandler, IDispos const b1 = src32[srcOffset++]; const b2 = src32[srcOffset++]; // Little-endian: pixel bytes are [R,G,B] → uint32 ABGR layout - dst32[dstOffset++] = (b0 & 0x00FFFFFF) | 0xFF000000; - dst32[dstOffset++] = ((b0 >>> 24) | (b1 << 8)) & 0x00FFFFFF | 0xFF000000; - dst32[dstOffset++] = ((b1 >>> 16) | (b2 << 16)) & 0x00FFFFFF | 0xFF000000; + dst32[dstOffset++] = b0 | 0xFF000000; + dst32[dstOffset++] = ((b0 >>> 24) | (b1 << 8)) | 0xFF000000; + dst32[dstOffset++] = ((b1 >>> 16) | (b2 << 16)) | 0xFF000000; dst32[dstOffset++] = (b2 >>> 8) | 0xFF000000; } From 0cea95d3b3f65737115456ead2e05e2c45700c49 Mon Sep 17 00:00:00 2001 From: Anthony Kim Date: Sun, 8 Mar 2026 20:33:01 -0700 Subject: [PATCH 2/2] Make code more readable --- addons/addon-image/src/kitty/KittyGraphicsHandler.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/addon-image/src/kitty/KittyGraphicsHandler.ts b/addons/addon-image/src/kitty/KittyGraphicsHandler.ts index 7964fe9c1..17cd5ed9f 100644 --- a/addons/addon-image/src/kitty/KittyGraphicsHandler.ts +++ b/addons/addon-image/src/kitty/KittyGraphicsHandler.ts @@ -752,10 +752,10 @@ export class KittyGraphicsHandler implements IApcHandler, IResetHandler, IDispos const b1 = src32[srcOffset++]; const b2 = src32[srcOffset++]; // Little-endian: pixel bytes are [R,G,B] → uint32 ABGR layout - dst32[dstOffset++] = b0 | 0xFF000000; - dst32[dstOffset++] = ((b0 >>> 24) | (b1 << 8)) | 0xFF000000; - dst32[dstOffset++] = ((b1 >>> 16) | (b2 << 16)) | 0xFF000000; - dst32[dstOffset++] = (b2 >>> 8) | 0xFF000000; + dst32[dstOffset++] = 0xFF000000 | b0; + dst32[dstOffset++] = 0xFF000000 | (b0 >>> 24) | (b1 << 8); + dst32[dstOffset++] = 0xFF000000 | (b1 >>> 16) | (b2 << 16); + dst32[dstOffset++] = 0xFF000000 | (b2 >>> 8); } // Handle remaining 1–3 pixels