From 52e71a253076b43fe93084418230023ec89e342d Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Fri, 4 May 2018 10:13:21 -0700 Subject: [PATCH] Support italic --- src/renderer/dom/DomRenderer.ts | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/renderer/dom/DomRenderer.ts b/src/renderer/dom/DomRenderer.ts index cf0c7988a..bbbfa66ce 100644 --- a/src/renderer/dom/DomRenderer.ts +++ b/src/renderer/dom/DomRenderer.ts @@ -14,6 +14,7 @@ import { RenderDebouncer } from '../../utils/RenderDebouncer'; const ROW_CONTAINER_CLASS = 'xterm-rows'; const BOLD_CLASS = 'xterm-bold'; +const ITALIC_CLASS = 'xterm-italic'; const CURSOR_CLASS = 'xterm-cursor'; const FG_CLASS_PREFIX = 'xterm-fg-'; const BG_CLASS_PREFIX = 'xterm-bg-'; @@ -113,6 +114,9 @@ export class DomRenderer extends EventEmitter implements IRenderer { `.xterm span.${BOLD_CLASS} {` + ` font-weight: ${this._terminal.options.fontWeightBold};` + `}` + + `.xterm span.${ITALIC_CLASS} {` + + ` font-style: italic;` + + `}` + `.xterm .${ROW_CONTAINER_CLASS}.${FOCUS_CLASS} .${CURSOR_CLASS} {` + ` background-color: #fff;` + ` color: #000;` + @@ -311,14 +315,8 @@ export class DomRenderer extends EventEmitter implements IRenderer { charElement.classList.add(BOLD_CLASS); } - // TODO: Handle italics - - if (flags & FLAGS.BOLD) { - // Convert the FG color to the bold variant - if (fg < 8) { - fg += 8; - } - charElement.classList.add(BOLD_CLASS); + if (flags & FLAGS.ITALIC) { + charElement.classList.add(ITALIC_CLASS); } charElement.textContent = char;