From 32ad3a18bf8812c369994d08f7fed8123ffd295c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Breitbart?= Date: Tue, 28 Apr 2026 20:42:38 +0200 Subject: [PATCH] disable wrong webgl tests --- addons/addon-webgl/test/WebglRenderer.test.ts | 3 ++- addons/addon-webgl/test/playwright.config.ts | 5 ++++- test/playwright/SharedRendererTests.ts | 15 ++++++++++----- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/addons/addon-webgl/test/WebglRenderer.test.ts b/addons/addon-webgl/test/WebglRenderer.test.ts index af61992ce..f8488da32 100644 --- a/addons/addon-webgl/test/WebglRenderer.test.ts +++ b/addons/addon-webgl/test/WebglRenderer.test.ts @@ -24,8 +24,9 @@ test.afterAll(async () => await ctx.page.close()); test.describe('WebGL Renderer Integration Tests', async () => { // HACK: webgl2 is often not supported in headless firefox on Linux // https://github.com/microsoft/playwright/issues/11566 + // also disable safari due to #5852 if (platform() === 'linux') { - test.skip(({ browserName }) => browserName === 'firefox'); + test.skip(({ browserName }) => browserName === 'firefox' || browserName === 'webkit'); } injectSharedRendererTests(ctxWrapper); diff --git a/addons/addon-webgl/test/playwright.config.ts b/addons/addon-webgl/test/playwright.config.ts index e2fe314e5..8200a4a8f 100644 --- a/addons/addon-webgl/test/playwright.config.ts +++ b/addons/addon-webgl/test/playwright.config.ts @@ -7,7 +7,10 @@ const config: PlaywrightTestConfig = { { name: 'Chromium', use: { - browserName: 'chromium' + browserName: 'chromium', + launchOptions: { + args: ['--enable-unsafe-swiftshader'] + } } }, { diff --git a/test/playwright/SharedRendererTests.ts b/test/playwright/SharedRendererTests.ts index 6754dc6f9..db5c4c073 100644 --- a/test/playwright/SharedRendererTests.ts +++ b/test/playwright/SharedRendererTests.ts @@ -169,7 +169,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void await pollFor(ctx.value.page, () => getCellColor(ctx.value, 8, 1), [0, 0, 0, 255]); }); - test('background 0-15 invisible', async () => { + // due to #5852 + test.skip('background 0-15 invisible', async () => { const theme: ITheme = { black: '#010203', red: '#040506', @@ -335,7 +336,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void } }); - test('background 16-255 invisible', async () => { + // due to #5852 + test.skip('background 16-255 invisible', async () => { let data = ''; for (let y = 0; y < 240 / 16; y++) { for (let x = 0; x < 16; x++) { @@ -715,7 +717,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void } }); - test('background true color grey invisible', async () => { + // due to #5852 + test.skip('background true color grey invisible', async () => { let data = ''; for (let y = 0; y < 16; y++) { for (let x = 0; x < 16; x++) { @@ -872,7 +875,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void await pollFor(ctx.value.page, () => getCellColor(ctx.value, 8, 2), [64, 64, 64, 255]); }); - test('should enforce half the contrast for dim cells', async () => { + // due to #5852 + test.skip('should enforce half the contrast for dim cells', async () => { const theme: ITheme = { background: '#ffffff', black: '#2e3436', @@ -1177,7 +1181,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void await pollFor(ctx.value.page, () => getCellColor(ctx.value, 2, 3), [0, 0, 255, 255]); await pollFor(ctx.value.page, () => getCellColor(ctx.value, 3, 3), [0, 0, 255, 255]); }); - test('#4758: multiple invisible text characters without SGR change should not be rendered', async () => { + // due to #5852 + test.skip('#4758: multiple invisible text characters without SGR change should not be rendered', async () => { // Regression test: #4758 when multiple invisible characters are used await ctx.value.proxy.writeln(`■\x1b[8m■■`); // Full refresh as the before result is the same as after