From 2146e4940daceeeda83d1e2c9dea2936bd1821e3 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Mon, 25 May 2026 17:42:22 -0700 Subject: [PATCH] fix(addon-search): normalize invalid highlightLimit values Clamp highlightLimit to a positive finite integer, falling back to the default when the option is missing or invalid. Co-authored-by: Cursor --- addons/addon-search/src/SearchAddon.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/addon-search/src/SearchAddon.ts b/addons/addon-search/src/SearchAddon.ts index 1f14ddc22..3aaae4ee1 100644 --- a/addons/addon-search/src/SearchAddon.ts +++ b/addons/addon-search/src/SearchAddon.ts @@ -54,7 +54,8 @@ export class SearchAddon extends Disposable implements ITerminalAddon, ISearchAp constructor(options?: Partial) { super(); - this._highlightLimit = options?.highlightLimit ?? Constants.DEFAULT_HIGHLIGHT_LIMIT; + const limit = options?.highlightLimit ?? Constants.DEFAULT_HIGHLIGHT_LIMIT; + this._highlightLimit = Number.isFinite(limit) && limit > 0 ? Math.floor(limit) : Constants.DEFAULT_HIGHLIGHT_LIMIT; } public activate(terminal: Terminal): void {